feat: Clean up invalid multi-column handling #6121
Annotations
4 errors and 4 notices
|
[firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:117:7 › Check SlashMenu Functionality › Should be able to create complex documents that match snapshots:
tests/src/utils/editor.ts#L47
3) [firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:117:7 › Check SlashMenu Functionality › Should be able to create complex documents that match snapshots
Error: expect(string).toMatchSnapshot(expected)
@@ -38,11 +38,11 @@
"type": "heading",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left",
- "level": 2,
+ "level": 1,
"isToggleable": false
},
"content": [
{
"type": "text",
Expected: /__w/BlockNote/BlockNote/tests/src/end-to-end/slashmenu/slashmenu.test.ts-snapshots/docStructureSnapshot-firefox-linux.json
Received: /__w/BlockNote/BlockNote/tests/test-results/slashmenu-slashmenu-Check--f99af-uments-that-match-snapshots-firefox/docStructureSnapshot-actual.json
at ../utils/editor.ts:47
45 | // Remove id from docs
46 | const doc = JSON.stringify(await getDoc(page), null, 2);
> 47 | expect(doc).toMatchSnapshot(`${name}.json`);
| ^
48 | }
49 |
at compareDocToSnapshot (/__w/BlockNote/BlockNote/tests/src/utils/editor.ts:47:15)
at /__w/BlockNote/BlockNote/tests/src/end-to-end/slashmenu/slashmenu.test.ts:141:5
|
|
[firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:42:7 › Check SlashMenu Functionality › Should be able to create h3:
tests/src/utils/editor.ts#L11
2) [firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:42:7 › Check SlashMenu Functionality › Should be able to create h3
TimeoutError: locator.waitFor: Timeout 1000ms exceeded.
Call log:
- waiting for locator('.bn-editor').locator('[data-content-type=heading][data-level="3"]')
at ../utils/editor.ts:11
9 | export async function waitForSelectorInEditor(page: Page, selector: string) {
10 | const editor = page.locator(EDITOR_SELECTOR);
> 11 | await editor.locator(selector).waitFor({
| ^
12 | state: "attached",
13 | timeout: 1000,
14 | });
at waitForSelectorInEditor (/__w/BlockNote/BlockNote/tests/src/utils/editor.ts:11:34)
at /__w/BlockNote/BlockNote/tests/src/end-to-end/slashmenu/slashmenu.test.ts:46:34
|
|
[firefox] › src/end-to-end/draghandle/draghandle.test.ts:143:7 › Check Draghandle functionality › Delete button should delete correct block:
tests/src/end-to-end/draghandle/draghandle.test.ts#L151
1) [firefox] › src/end-to-end/draghandle/draghandle.test.ts:143:7 › Check Draghandle functionality › Delete button should delete correct block
Error: page.hover: Target page, context or browser has been closed
Call log:
- waiting for locator('[data-content-type=heading][data-level="2"]')
149 | await page.keyboard.type("This is h3");
150 |
> 151 | await page.hover(H_TWO_BLOCK_SELECTOR);
| ^
152 | await page.click(DRAG_HANDLE_SELECTOR);
153 | await page.click("text=Delete");
154 | await page.waitForSelector(H_ONE_BLOCK_SELECTOR);
at /__w/BlockNote/BlockNote/tests/src/end-to-end/draghandle/draghandle.test.ts:151:16
|
|
[firefox] › src/end-to-end/draghandle/draghandle.test.ts:143:7 › Check Draghandle functionality › Delete button should delete correct block:
tests/src/end-to-end/draghandle/draghandle.test.ts#L0
1) [firefox] › src/end-to-end/draghandle/draghandle.test.ts:143:7 › Check Draghandle functionality › Delete button should delete correct block
Test timeout of 30000ms exceeded.
|
|
🎭 Playwright Run Summary
1 skipped
94 passed (2.3m)
|
|
🎭 Playwright Run Summary
9 skipped
86 passed (3.1m)
|
|
🎭 Playwright Run Summary
3 flaky
[firefox] › src/end-to-end/draghandle/draghandle.test.ts:143:7 › Check Draghandle functionality › Delete button should delete correct block
[firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:42:7 › Check SlashMenu Functionality › Should be able to create h3
[firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:117:7 › Check SlashMenu Functionality › Should be able to create complex documents that match snapshots
11 skipped
81 passed (3.4m)
|
|
Build
{
"workflowData": {
"owner": "TypeCellOS",
"repo": "BlockNote",
"sha": "38d2f7471cd0da959a929930d53a75bc95125b4e",
"ref": "2113"
},
"key": "9949KRgQOr",
"runId": 18649226418,
"webhookDebug": {
"action": "requested",
"head_branch": "multi-column-block-delete-fix-2",
"head_repository_full_name": "TypeCellOS/BlockNote",
"full_name": "TypeCellOS/BlockNote",
"isPullRequest": true,
"prNumber": 2113,
"prNumberType": "number",
"isNewPullRequest": true,
"isOldPullRequest": false,
"prKey": "TypeCellOS/BlockNote:multi-column-block-delete-fix-2",
"oldPrDataHash": "18No3fdjv6",
"lookupKey": "TypeCellOS/BlockNote:multi-column-block-delete-fix-2",
"data": {
"owner": "TypeCellOS",
"repo": "BlockNote",
"sha": "38d2f7471cd0da959a929930d53a75bc95125b4e",
"ref": "2113"
}
}
}
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
playwright-report-chromium
Expired
|
263 KB |
sha256:ecd0148faa6eab4d68d25ca23dea3659ca8ee1708af2cc8ad9acd3274c2f2383
|
|
|
playwright-report-firefox
Expired
|
1.95 MB |
sha256:8f8a06239f3a2a3a21a710d4d5fa1df28973b6d54a3d9b9d9e4111730efd8e0b
|
|
|
playwright-report-webkit
Expired
|
260 KB |
sha256:6c9253188f7306f0bf5fe996a76da45fd2b880784cb09820255835974b82f436
|
|
|
relative-ci-artifacts-editor
Expired
|
46.9 KB |
sha256:731d0fd056178af923844667dc5c773e7f492a747fc037a2d94946f99b80f37f
|
|