Skip to content

Few questions about model code #1

@jingweim

Description

@jingweim

Hi authors,

Great work on this project! I have a few questions regarding the Tracktention implementation in your code:

  1. Feature Output vs. Residuals: The module currently outputs the track-smoothed features directly (updated_feature_map), rather than a residual that modifies the original feature as described in the Tracktention paper. Is there a specific reason for implementing this way?
  2. Initialization in Forward Pass: I noticed a nn.Linear layer being initialized inside the forward function. Is this a bug?
  3. Single-sided RoPE: Rotary Positional Embeddings (RoPE) are only applied to Q during splatting and only to K during sampling. Usually, Q and K are rotated together to maintain relative positional information; what is the intuition behind using single-sided RoPE here?

Thanks for your help!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions