From ee9b781394e7cbdcc8b62630428829e49de176d7 Mon Sep 17 00:00:00 2001 From: Remco Burema Date: Tue, 3 Mar 2026 10:39:58 +0100 Subject: [PATCH 1/3] Be able to handle writing big zip-files. CURA-12983 --- Charon/filetypes/OpenPackagingConvention.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Charon/filetypes/OpenPackagingConvention.py b/Charon/filetypes/OpenPackagingConvention.py index f5d8e6f..21c36f7 100644 --- a/Charon/filetypes/OpenPackagingConvention.py +++ b/Charon/filetypes/OpenPackagingConvention.py @@ -192,7 +192,7 @@ def getStream(self, virtual_path: str) -> IO[bytes]: self._last_open_path = virtual_path try: # If it happens to match some existing PNG file, we have to rescale that file and return the result. - self._last_open_stream = self._zipfile.open(virtual_path, self._mode.value) + self._last_open_stream = self._zipfile.open(virtual_path, self._mode.value, force_zip64=True) except RuntimeError: # Python 3.5 and before couldn't open resources in the archive in write mode. self._last_open_stream = BytesIO() self._open_bytes_streams[virtual_path] = self._last_open_stream # Save this for flushing later. From 2b5fcda5bc34f8c95fafc68b3ceefcb16297f967 Mon Sep 17 00:00:00 2001 From: HellAholic Date: Tue, 3 Mar 2026 13:30:12 +0100 Subject: [PATCH 2/3] Remove unnecessary dependencies from Release job --- .github/workflows/build_on_push_pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build_on_push_pr.yml b/.github/workflows/build_on_push_pr.yml index af15ef1..7fd182c 100644 --- a/.github/workflows/build_on_push_pr.yml +++ b/.github/workflows/build_on_push_pr.yml @@ -63,7 +63,7 @@ jobs: Release_Package: name: 'Release' - needs: [Prepare, Shellcheck, Build, Flake8, MyPy, PyCodeStyle, Vulture, PyTest] + needs: [Prepare, Shellcheck, Build, MyPy, Vulture, PyTest] if: ${{ (success() && needs.Prepare.outputs.RELEASE_REPO != 'none') || (failure() && needs.Build.result == 'success' && needs.Prepare.outputs.RELEASE_REPO == 'packages-dev') }} uses: Ultimaker/embedded-workflows/.github/workflows/release_pkg.yml@main From 581c74419ca7ead64dde174900e4b2ca6633594d Mon Sep 17 00:00:00 2001 From: HellAholic Date: Tue, 3 Mar 2026 13:33:33 +0100 Subject: [PATCH 3/3] Disable Flake8 and PyCodeStyle checks Comment out Flake8 and PyCodeStyle jobs in the workflow. --- .github/workflows/build_on_push_pr.yml | 28 +++++++++++++------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/workflows/build_on_push_pr.yml b/.github/workflows/build_on_push_pr.yml index 7fd182c..85dbcb9 100644 --- a/.github/workflows/build_on_push_pr.yml +++ b/.github/workflows/build_on_push_pr.yml @@ -17,13 +17,13 @@ jobs: uses: Ultimaker/embedded-workflows/.github/workflows/shellcheck.yml@main secrets: inherit - Flake8: - name: 'Test' - needs: Prepare - uses: Ultimaker/python-quality-control/.github/workflows/flake8.yml@master - with: - PARENT_BRANCH: 'main' - secrets: inherit + # Flake8: + # name: 'Test' + # needs: Prepare + # uses: Ultimaker/python-quality-control/.github/workflows/flake8.yml@master + # with: + # PARENT_BRANCH: 'main' + # secrets: inherit MyPy: name: 'Test' @@ -33,13 +33,13 @@ jobs: PARENT_BRANCH: 'main' secrets: inherit - PyCodeStyle: - name: 'Test' - needs: Prepare - uses: Ultimaker/python-quality-control/.github/workflows/pycodestyle.yml@master - with: - PARENT_BRANCH: 'main' - secrets: inherit + # PyCodeStyle: + # name: 'Test' + # needs: Prepare + # uses: Ultimaker/python-quality-control/.github/workflows/pycodestyle.yml@master + # with: + # PARENT_BRANCH: 'main' + # secrets: inherit Vulture: name: 'Test'