Revert private to internal change

Author: noellie-velez

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs

@@ -670,7 +670,7 @@ internal void UpdateNetworkProperties()
                 IsClient = m_NetworkManager.IsListening && m_NetworkManager.IsClient;
                 IsServer = m_NetworkManager.IsListening && m_NetworkManager.IsServer;
                 IsSessionOwner = m_NetworkManager.IsListening && m_NetworkManager.LocalClient.IsSessionOwner;
-                HasAuthority = m_NetworkObject.InternalHasAuthority();
+                HasAuthority = m_NetworkObject.HasAuthority;
                 ServerIsHost = m_NetworkManager.IsListening && m_NetworkManager.ServerIsHost;
             }
         }

com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

@@ -1153,7 +1153,7 @@ public bool HasOwnershipStatus(OwnershipStatus status)
         public bool HasAuthority => InternalHasAuthority();
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        internal bool InternalHasAuthority()
+        private bool InternalHasAuthority()
         {
             var networkManager = NetworkManager;
             return networkManager.DistributedAuthorityMode ? OwnerClientId == networkManager.LocalClientId : networkManager.IsServer;

com.unity.netcode.gameobjects/Runtime/SceneManagement/DefaultSceneManagerHandler.cs

@@ -302,7 +302,7 @@ public void MoveObjectsFromSceneToDontDestroyOnLoad(ref NetworkManager networkMa
                 }
 
                 // Check to determine if we need to allow destroying a non-authority instance
-                if (distributedAuthority && networkObject.DestroyWithScene && !networkObject.InternalHasAuthority())
+                if (distributedAuthority && networkObject.DestroyWithScene && !networkObject.HasAuthority)
                 {
                     networkObject.DestroyPendingSceneEvent = true;
                 }
@@ -316,7 +316,7 @@ public void MoveObjectsFromSceneToDontDestroyOnLoad(ref NetworkManager networkMa
                         UnityEngine.Object.DontDestroyOnLoad(networkObject.gameObject);
                     }
                 }
-                else if (networkObject.InternalHasAuthority())
+                else if (networkObject.HasAuthority)
                 {
                     // We know this instance is going to be destroyed (when it receives the destroy object message).
                     // We have to invoke this prior to invoking despawn in order to know that we are de-spawning in

com.unity.netcode.gameobjects/Runtime/SceneManagement/NetworkSceneManager.cs

@@ -2713,7 +2713,7 @@ internal void MoveObjectsToDontDestroyOnLoad()
                 }
 
                 // Check to determine if we need to allow destroying a non-authority instance
-                if (distributedAuthority && networkObject.DestroyWithScene && !networkObject.InternalHasAuthority())
+                if (distributedAuthority && networkObject.DestroyWithScene && !networkObject.HasAuthority)
                 {
                     networkObject.DestroyPendingSceneEvent = true;
                 }
@@ -2731,7 +2731,7 @@ internal void MoveObjectsToDontDestroyOnLoad()
                         networkObject.SceneOriginHandle = networkObject.gameObject.scene.handle;
                     }
                 }
-                else if (networkObject.InternalHasAuthority())
+                else if (networkObject.HasAuthority)
                 {
                     networkObject.SetIsDestroying();
                     // Only destroy non-scene placed NetworkObjects to avoid warnings about destroying in-scene placed NetworkObjects.
@@ -2889,7 +2889,7 @@ internal bool IsSceneUnloading(NetworkObject networkObject)
         internal void NotifyNetworkObjectSceneChanged(NetworkObject networkObject)
         {
             // Really, this should never happen but in case it does
-            if (!networkObject.InternalHasAuthority())
+            if (!networkObject.HasAuthority)
             {
                 if (NetworkManager.LogLevel == LogLevel.Developer)
                 {

com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs

@@ -1574,7 +1574,7 @@ internal void ServerDestroySpawnedSceneObjects()
                 if (networkObject.InScenePlaced && networkObject.DestroyWithScene
                     && networkObject.gameObject.scene != NetworkManager.SceneManager.DontDestroyOnLoadScene)
                 {
-                    if (networkObject.IsSpawned && networkObject.InternalHasAuthority())
+                    if (networkObject.IsSpawned && networkObject.HasAuthority)
                     {
                         networkObject.Despawn(false);
                     }
@@ -1729,7 +1729,7 @@ internal void ServerSpawnSceneObjectsOnStartSweep()
         /// </summary>
         internal void OnDespawnNonAuthorityObject([NotNull] NetworkObject networkObject, bool destroyGameObject)
         {
-            if (networkObject.InternalHasAuthority())
+            if (networkObject.HasAuthority)
             {
                 if (NetworkManager.LogLevel <= LogLevel.Error)
                 {
@@ -1806,7 +1806,7 @@ internal void OnDespawnObject([NotNull] NetworkObject networkObject, bool destro
                     }
                     // For mixed authority hierarchies, if the parent is despawned then any removal of children
                     // is considered "authority approved". Set the AuthorityAppliedParenting flag.
-                    spawnedNetObj.AuthorityAppliedParenting = distributedAuthority && !networkObject.InternalHasAuthority();
+                    spawnedNetObj.AuthorityAppliedParenting = distributedAuthority && !networkObject.HasAuthority;
 
                     // Try to remove the parent using the cached WorldPositionStays value
                     // Note: WorldPositionStays will still default to true if this was an
@@ -1834,7 +1834,7 @@ internal void OnDespawnObject([NotNull] NetworkObject networkObject, bool destro
             networkObject.InvokeBehaviourNetworkDespawn();
 
             // Whether we are in distributedAuthority mode and have authority on this object
-            var hasDAAuthority = distributedAuthority && (networkObject.InternalHasAuthority() || (NetworkManager.DAHost && authorityOverride));
+            var hasDAAuthority = distributedAuthority && (networkObject.HasAuthority || (NetworkManager.DAHost && authorityOverride));
 
             // Don't send messages if shutting down
             // Otherwise send messages if we are the authority (either the server, or the DA mode authority of this object).