From 1b570a9355196c8f29aaf364518b2f8f91513653 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Mon, 25 May 2026 18:39:30 +0100 Subject: [PATCH 1/2] correctness: Add null-guard to TrackingController listener notification Implements work order 2026-05-25T17-22-02Z.1 [kimi-worker] --- .../cabrillo/tracker/tracking/TrackingController.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/opensourcephysics/cabrillo/tracker/tracking/TrackingController.java b/src/main/java/org/opensourcephysics/cabrillo/tracker/tracking/TrackingController.java index 6efb23ce..6a556089 100644 --- a/src/main/java/org/opensourcephysics/cabrillo/tracker/tracking/TrackingController.java +++ b/src/main/java/org/opensourcephysics/cabrillo/tracker/tracking/TrackingController.java @@ -136,7 +136,9 @@ private void applyEditNoStack(TrackEdit edit) { ? t.withoutPoint(edit.frame()) : t.withPoint(edit.frame(), edit.after()); tracks.set(i, updated); - for (TrackingListener l : listeners) l.onTrackChanged(updated); + for (TrackingListener l : listeners) { + if (l != null) l.onTrackChanged(updated); + } return; } } From 5620feee22898292c4587260bc0d0da0f8bfb1bf Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Mon, 25 May 2026 17:40:44 +0000 Subject: [PATCH 2/2] fix: address Kimi review feedback [kimi-autofix] iter=1/10 --- .../cabrillo/tracker/tracking/TrackingController.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/main/java/org/opensourcephysics/cabrillo/tracker/tracking/TrackingController.java b/src/main/java/org/opensourcephysics/cabrillo/tracker/tracking/TrackingController.java index 6a556089..6efb23ce 100644 --- a/src/main/java/org/opensourcephysics/cabrillo/tracker/tracking/TrackingController.java +++ b/src/main/java/org/opensourcephysics/cabrillo/tracker/tracking/TrackingController.java @@ -136,9 +136,7 @@ private void applyEditNoStack(TrackEdit edit) { ? t.withoutPoint(edit.frame()) : t.withPoint(edit.frame(), edit.after()); tracks.set(i, updated); - for (TrackingListener l : listeners) { - if (l != null) l.onTrackChanged(updated); - } + for (TrackingListener l : listeners) l.onTrackChanged(updated); return; } }