Skip to content

No SystemVerilog support for add_from_compile_order_file in vivado.py #2

Description

@LarsAsplund

This issue was moved from VUnit/vunit#796.


There is no support for SystemVerilog files when using the add_from_compile_order_file function. It currently only support VHDL, Verilog and Verilog Headers. Currently it fails on an assert if a SystemVerilog file type exist in the generated compile_order.txt file.

Support can be added by changing:

vunit/vivado/vivado.py

from:
30    with_dependency_scan = []
31    for library_name, file_name in compile_order:
32        is_verilog = file_name.endswith(".v") or file_name.endswith(".vp")

to:
30    with_dependency_scan = []
31    for library_name, file_name in compile_order:
32        is_verilog = file_name.endswith(".v") or file_name.endswith(".vp") or file_name.endswith(".sv")
and

vunit/vivado/vivado.py

from:
91        for line in ifile.readlines():
92            library_name, file_type, file_name = line.strip().split(",", 2)
93            assert file_type in ("Verilog", "VHDL", "Verilog Header")
94            libraries.add(library_name)

to:
91        for line in ifile.readlines():
92            library_name, file_type, file_name = line.strip().split(",", 2)
93            assert file_type in ("Verilog", "VHDL", "Verilog Header",  "SystemVerilog")
94            libraries.add(library_name)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions