Refactor code structure for improved readability and maintainability#81
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Install uv (one time) | ||
| pip install uv | ||
|
|
||
| # Install dependencies | ||
| pip install -r requirements.txt | ||
| # Sync dependencies from lockfile (creates .venv) | ||
| uv sync --frozen --no-install-project |
There was a problem hiding this comment.
The Quick Start now tells users to pip install uv and run uv sync --frozen --no-install-project but never tells them to activate .venv or to run commands via uv run. On a clean machine this leaves the global interpreter in use, so the next Python commands in the guide (e.g., running scripts/setup_config.sh followed by python ... later in the README) will execute without the dependencies that were just installed into .venv, resulting in ModuleNotFoundError for packages like pydantic or httpx. The instructions need to include activating .venv or consistently using uv run so that following the README actually yields a working environment.
Useful? React with 👍 / 👎.
| ### Installation | ||
| ```bash | ||
| # 1. Install Python dependencies | ||
| pip install -r requirements.txt | ||
| # 1. Install uv (one time) | ||
| pip install uv | ||
|
|
||
| # 2. Sync dependencies from lockfile (creates .venv) | ||
| uv sync --frozen --no-install-project |
There was a problem hiding this comment.
The updated installation steps install uv and run uv sync --frozen --no-install-project but never switch the shell to use the created .venv nor suggest running subsequent Python commands via uv run. Anyone following AGENTS.md on a fresh system will keep using the system interpreter, so later commands like the configuration sanity check python -c "from src.config.settings import get_settings; ..." will fail because the dependencies were installed only into .venv. The setup section should explicitly activate .venv (or wrap commands with uv run) so that the documented workflow actually works.
Useful? React with 👍 / 👎.
1 participant
No description provided.