fix(visualize): address xhigh code-review findings

Correctness/UX:
- search & inspector link-jump now set autoFit=false so centerOn() actually
  centres the node instead of being overwritten by the per-frame fit
- setMode clears in-flight interaction (drag/orbiting/pendingInspect/cursor),
  releases pins, and syncs the search box — no stale state across views
- cap fitStep zoom so a 1-node KB can't balloon past the zoom range
- guard adj[focus] in the graph hl-loop (matches the radial branch)

Cleanup (post-churn):
- extract shared buildProvenance() (was duplicated in mind-map + radial)
- drop dead MODE_LABEL, unused 'kn', tombstone comment, unused ROOT fields,
  and the redundant first-pass n.show reset in layoutRadial

Author: KylinMountain

openkb/templates/graph.html

@@ -290,8 +290,7 @@
 let didDrag = false;
 let alpha = 1;                   // simulated-annealing "temperature"; cools to 0 so motion stops
 // synthetic centre for the radial view ("OpenKB" → documents → concepts)
-const ROOT = { id:"__openkb__", label:"OpenKB", type:"__root__", x:0, y:0, z:0, tx:0, ty:0,
-  sx:0, sy:0, rz:0, pp:1, r:15, hl:1, alpha:1, depth:0, show:true };
+const ROOT = { id:"__openkb__", label:"OpenKB", type:"__root__", x:0, y:0, sx:0, sy:0, rz:0, pp:1, r:15, show:true };
 let treeEdges = [];              // radial hierarchy edges (root→doc, doc→concept)
 const DEFAULT_SPREAD = 1.7;      // open the nebula out by default so it isn't a clump
 let spread = DEFAULT_SPREAD;     // spacing knob: >1 spreads nodes apart, <1 packs them tighter
@@ -327,9 +326,8 @@
 let mmQuery = "", mmRootY = 0;
 const mmResolveSrc = s => { const id = String(s).replace(/\.md$/i, ""); return (byId[id] && byId[id].id.startsWith("summaries/")) ? id : null; };
 const ROOT_W = 104, NODE_W = 184, COL = 234, ROW = 31, PADX = 34, PADY = 30, NH = 22;
-function buildMindmap(){
-  const q = mmQuery.toLowerCase();
-  const keep = n => !q || n.label.toLowerCase().includes(q) || n.id.toLowerCase().includes(q);
+// shared OpenKB → documents → concepts grouping (each concept under its primary source summary)
+function buildProvenance(){
   const docs = nodes.filter(n => n.id.startsWith("summaries/") && typeVisible(n.type));
   const kidsOf = {}; docs.forEach(d => kidsOf[d.id] = []);
   const rootDirect = [];
@@ -338,6 +336,12 @@
     const p = (n.sources || []).map(mmResolveSrc).filter(Boolean)[0];   // primary document
     if(p && kidsOf[p]) kidsOf[p].push(n); else rootDirect.push(n);
   });
+  return { docs, kidsOf, rootDirect };
+}
+function buildMindmap(){
+  const q = mmQuery.toLowerCase();
+  const keep = n => !q || n.label.toLowerCase().includes(q) || n.id.toLowerCase().includes(q);
+  const { docs, kidsOf, rootDirect } = buildProvenance();
   const mk = n => ({ id:n.id, label:n.label, type:n.type, kids:[] });
   const root = { id:"__openkb__", label:"OpenKB", type:"__root__", kids:[] };
   docs.forEach(d => {
@@ -374,7 +378,7 @@
   let html = "";
   flat.forEach(it => {
     if(it.id === "__openkb__"){ html += `<div class="mm-node mm-root" style="left:${it.x}px;top:${it.y - 4}px">OpenKB</div>`; return; }
-    const col = colorOf(it.type), kn = it.kids.length || (mmCollapsed.has(it.id) ? 1 : 0);
+    const col = colorOf(it.type);
     const hasKids = it.id.startsWith("summaries/") && (kidsOf[it.id] || []).length;
     html += `<div class="mm-node" data-id="${esc(it.id)}" title="${esc(it.label)}" `
       + `style="left:${it.x}px;top:${it.y}px;border-color:rgba(${col},.5);background:rgba(${col},.12)">`
@@ -395,14 +399,7 @@
 
 /* ===================== radial view: same OpenKB→docs→concepts tree, fanned in a circle ===================== */
 function layoutRadial(){
-  const docs = nodes.filter(n => n.id.startsWith("summaries/") && typeVisible(n.type));
-  const kidsOf = {}; docs.forEach(d => kidsOf[d.id] = []);
-  const rootDirect = [];
-  nodes.forEach(n => {
-    if(n.id.startsWith("summaries/") || !typeVisible(n.type)){ n.show = false; return; }
-    const p = (n.sources || []).map(mmResolveSrc).filter(Boolean)[0];
-    if(p && kidsOf[p]) kidsOf[p].push(n); else rootDirect.push(n);
-  });
+  const { docs, kidsOf, rootDirect } = buildProvenance();
   nodes.forEach(n => { n.show = false; });
   const branches = docs.map(d => ({ node: d, kids: kidsOf[d.id], w: Math.max(1.6, kidsOf[d.id].length) }))
     .concat(rootDirect.map(c => ({ node: c, kids: [], w: 1 })));
@@ -476,14 +473,16 @@
 }
 
 const spacingCtl = document.getElementById("spacingCtl");
-const MODE_LABEL = { mindmap: "mind-map", radial: "radial", graph: "3D" };
 function setMode(m){
   mode = m;
   const canvasMode = (m === "graph" || m === "radial");   // canvas: 3D nebula + radial. mind-map is DOM
   canvas.style.display = canvasMode ? "block" : "none";
   mmEl.style.display = (m === "mindmap") ? "block" : "none";
   spacingCtl.style.display = (m === "mindmap") ? "none" : "flex";
   hover = null; closePanel(); panX = 0; panY = 0; autoFit = true;
+  drag = null; orbiting = false; pendingInspect = null; didDrag = false; canvas.style.cursor = "grab";  // clear in-flight interaction
+  nodes.forEach(n => n.pinned = false);                  // pins don't carry across views / reseed
+  search.value = ""; mmQuery = "";                       // keep the search box in sync with the (cleared) filter
   if(m === "mindmap"){ buildMindmap(); mmEl.scrollTop = Math.max(0, mmRootY - mmEl.clientHeight / 2); }
   else if(m === "radial"){ yaw = 0; pitch = 0; scale = DEF_SCALE; layoutRadial(); alpha = 1; }
   else { yaw = DEF_YAW; pitch = DEF_PITCH; scale = DEF_SCALE; seed(); alpha = 1; }
@@ -540,7 +539,7 @@
   if(maxX <= minX || maxY <= minY) return;
   const cx = (minX + maxX) / 2, cy = (minY + maxY) / 2;
   const factor = Math.min(W() * 0.9 / (maxX - minX), H() * 0.88 / (maxY - minY));
-  const tScale = scale * factor;
+  const tScale = Math.min(scale * factor, 4);   // cap so a tiny graph (e.g. 1 node) doesn't balloon past the zoom range
   const Xc = (cx - (W()/2 + panX)) / scale, Yc = (cy - (H()/2 + panY)) / scale;
   const tPanX = -Xc * tScale, tPanY = -Yc * tScale;
   const e = 0.07;                                   // ease 7%/frame → smooth glide into frame
@@ -702,7 +701,6 @@
     ctx.beginPath(); ctx.arc(x - r*0.28, y - r*0.28, r*0.3, 0, TAU);
     ctx.fillStyle = `rgba(255,255,255,${0.35*fog})`; ctx.fill();
   }
-  // (flat discs — no glossy core highlight)
   // label — declutter: hubs at rest; hovered node + neighbors; selection; zoomed in; near depth only
   const showLabel = (mode === "radial" && n.depth <= 1) || (scale > 1.4) || (n.id === selected) || (hover ? hl > 0.55 : labelIds.has(n.id));
   if(showLabel && fog > 0.55){
@@ -742,7 +740,7 @@
     if(alpha < 0.05 && idleFrames > 150) yaw += 0.0011;   // gentle auto-rotation once settled & idle
     const focus = hover || selected;   // hover/selection spotlights a node + its neighbours
     for(const n of nodes){
-      const near = !focus || n.id===focus || adj[focus].has(n.id);
+      const near = !focus || n.id===focus || (adj[focus] && adj[focus].has(n.id));
       n.hl += ((near ? 1 : 0.22) - n.hl) * 0.12;
     }
     ctx.setTransform(DPR,0,0,DPR,0,0);
@@ -832,7 +830,7 @@
   panel.querySelectorAll("[data-n]").forEach(a => a.onclick = () => {
     const m = byId[a.dataset.n];
     if(!m) return;
-    if(mode === "graph" || mode === "radial"){ hover = m.id; centerOn(m); }   // canvas views: bring it into view
+    if(mode === "graph" || mode === "radial"){ hover = m.id; autoFit = false; centerOn(m); }   // canvas views: bring it into view (stop auto-fit so the pan sticks)
     openPanel(m);                                        // all modes: show its details
   });
 }
@@ -865,7 +863,7 @@
   if(!q){ hover = null; return; }
   const m = nodes.find(n => n.label.toLowerCase().includes(q))
          || nodes.find(n => n.id.toLowerCase().includes(q));
-  if(m){ hover = m.id; centerOn(m); }
+  if(m){ hover = m.id; autoFit = false; centerOn(m); }   // stop auto-fit so the centring sticks
 });
 search.addEventListener("keydown", e => {
   if(e.key === "Enter"){