Skip to content

Commit 357eac2

Browse files
committed
fix(converter): move keep_data_uris to convert call and fix lint
1 parent 3889e97 commit 357eac2

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

openkb/converter.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,8 @@ def convert_document(
231231
markdown = convert_pdf_with_images(src, doc_name, images_dir)
232232
else:
233233
# Non-PDF, non-MD: use markitdown (docx, pptx, html, etc.)
234-
mid = MarkItDown(keep_data_uris=True)
235-
result = mid.convert(str(src))
234+
mid = MarkItDown()
235+
result = mid.convert(str(src), keep_data_uris=True)
236236
markdown = result.text_content
237237
markdown = extract_base64_images(markdown, doc_name, images_dir)
238238

tests/test_converter.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,14 +146,17 @@ def test_docx_conversion_enables_keep_data_uris(self, kb_dir, tmp_path):
146146

147147
with (
148148
patch("openkb.converter.MarkItDown") as mock_markitdown,
149-
patch("openkb.converter.extract_base64_images", return_value="converted markdown") as mock_extract,
149+
patch(
150+
"openkb.converter.extract_base64_images",
151+
return_value="converted markdown",
152+
) as mock_extract,
150153
):
151154
mock_markitdown.return_value.convert.return_value = mock_result
152155

153156
result = convert_document(src, kb_dir)
154157

155-
mock_markitdown.assert_called_once_with(keep_data_uris=True)
156-
mock_markitdown.return_value.convert.assert_called_once_with(str(src))
158+
mock_markitdown.assert_called_once_with()
159+
mock_markitdown.return_value.convert.assert_called_once_with(str(src), keep_data_uris=True)
157160
mock_extract.assert_called_once()
158161
assert result.skipped is False
159162
assert result.is_long_doc is False

0 commit comments

Comments
 (0)