Skip to content

Commit a6ae2bd

Browse files
committed
refactor(config): keep concurrency out of DEFAULT_CONFIG (align with other optional knobs)
Every other optional tuning knob (timeout, extra_headers, litellm, entity_types, parallel_tool_calls) is resolved via its resolver's .get() and lives only in config.yaml.example, not DEFAULT_CONFIG — which holds just the core keys openkb init writes (model, language, pageindex_threshold). concurrency was the lone exception; resolve_concurrency already reads it via .get(), so the DEFAULT_CONFIG entry was redundant. Remove it for consistency.
1 parent 49503be commit a6ae2bd

2 files changed

Lines changed: 6 additions & 9 deletions

File tree

openkb/config.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,6 @@
1717
"model": "gpt-5.4",
1818
"language": "en",
1919
"pageindex_threshold": 20,
20-
# Cap on concurrent LLM calls OpenKB makes during ingest — both PageIndex's
21-
# indexing of a long document and OpenKB's own concept/entity compilation.
22-
# These never run concurrently with each other for the same document, so
23-
# one knob covers both. None = each stage applies its own built-in default.
24-
# Lower it if you hit provider rate limits or "too many open files"; raise
25-
# it to go faster.
26-
"concurrency": None,
2720
}
2821

2922
# Default entity-type vocabulary. Overridable per-KB via the optional

tests/test_config.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,12 @@ def test_default_config_values():
136136
assert DEFAULT_CONFIG["pageindex_threshold"] == 20
137137

138138

139-
def test_concurrency_defaults_to_none():
140-
assert DEFAULT_CONFIG["concurrency"] is None
139+
def test_concurrency_not_in_default_config():
140+
# Like the other optional tuning knobs (timeout, extra_headers,
141+
# parallel_tool_calls), concurrency stays out of DEFAULT_CONFIG —
142+
# resolve_concurrency reads it via .get(), so an absent key resolves to
143+
# None without relying on load_config's merge.
144+
assert "concurrency" not in DEFAULT_CONFIG
141145

142146

143147
def test_load_concurrency_override(tmp_path):

0 commit comments

Comments
 (0)