Comments on HLIL are frequently not placed on the correct line

[plafosse]

As function comments are only placed on addresses HLIL comments frequently are placed on an untended instruction. To solve this we would likely need to store additional data in addition to the address in order to find the proper location to place comments.

This issue is partially mitigated by providing better HLIL address mappings.

[ntheis-anvilsecure]

As a workaround, it would be useful to at least be able to force comments to be displayed on a certain HLIL statement - at the moment, it's not uncommon to encounter e.g. a branch of an if-elseif-else on which no comments whatsoever can be placed in HLIL (they always show up somewhere else), which is quite frustrating.

[mattraneri]

As a workaround, it would be useful to at least be able to force comments to be displayed on a certain HLIL statement - at the moment, it's not uncommon to encounter e.g. a branch of an if-elseif-else on which no comments whatsoever can be placed in HLIL (they always show up somewhere else), which is quite frustrating.

Agree with this-
things get especially bad with switch statements, placing all comments at the top of the switch

[CouleeApps]

This has been improved as of 2.5.3158-dev, see #2792 (comment). There is still the problem of duplicate addresses leading to duplicate comments in HLIL, which is what this issue tracks.

[0xdevalias]

Potentially related:

• Make comment placement configurable. #708
• Questionable comment placement near else block #4464

[plafosse]

Potentially related to this: #3754