Skip to content

Don't wait for request to time out before closing Plugin Manager #4748

@fuzyll

Description

@fuzyll

Related to #4746, if you have a third-party plugin repository configured that can't be reached, actions like closing the plugin manager will cause the UI to hang until the request times out.

To repro, just add Sidekick from the staging repo and then wait for the Sidekick team to take the server down. Then, open the Plugin Manager, do something in it (like searching for a plugin), and then try to close the tab. Observe that Binary Ninja is completely stuck until the request times out and the following is printed in the log:

[Plugin Repository: sidekick error] Unable to download plugins.json

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: UIIssue needs changes to the user interfaceEffort: LowIssues require < 1 week of workImpact: LowIssue is a papercut or has a good, supported workaround

    Type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions