Incorrect message displayed for platform setting in OwO with raw binaries

[zznop]

4.2.6455

• Binary Ninja Version: 4.2.6455 (all editions)
• OS: All
• CPU Architecture: All

Bug Description:
Message for the loader.platform setting incorrectly displayed as No platform identified, defaulting to "x86" when loading most raw binaries with Mapped and VxWorks views.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

1. Go to "Open with Options"
2. Click on a non-x86 raw binary that Binja is known to correctly predict the architecture for
3. See that the platform is set correctly, but the setting message indicates that it's using the default platform (x86)

Note: this only occurs if a single architecture is detected. If our auto-architecture detection detects >1 candidate architectures, then the correct message is displayed (this is how it got past my limited spot testing).

Expected Behavior:
Only display that message for raw binaries in which auto-detection fails and we default to x86

Additional Information:
This bug is a result of a bad "fix" I implemented for demo version right before the release of 4.2.6455 stable. Commit hash in binaryninja that introduces the bug is: 6a38fad94daaf6322d2f5f11f19ef46f6ed985ac

[zznop]

Fixed in 4.3.6594-dev with this commit: https://github.com/Vector35/binaryninja/commit/c7f7c5e4a4eff103a06e95e602ee48da8c730efb