Skip to content

Tag Type Visibility Not Captured by Undo Actions #6801

@utkonos

Description

@utkonos

Version and Platform (required):

  • Binary Ninja Version: 5.0.7290
  • OS: macOS
  • OS Version: 15.4.1
  • CPU Architecture: x64

Bug Description:
If a tag type's visibility is changed during a set of undo actions, the visibility is not reverted at the undo. This is despite there being a specific line item in the History if you make one tag visibility change.

Steps To Reproduce:

  1. Open a database.
  2. Make a tag at an address
  3. Run this and note that the tag type visibility state is all false after undo.
state = bv.begin_undo_actions()
for tag_type in bv.tag_types.values():
    tag_type.visible = False
bv.commit_undo_actions(state)
bv.undo()

Expected Behavior:
Tag type visibility state reverts to before undo actions start.

Screenshots/Video Recording:
Here you can see a single line item in History for the tag type visibility change, but for some reason when you use begin_undo_actions, this item is not included in the list of actions to undo.

Image

Metadata

Metadata

Assignees

Labels

Component: CoreIssue needs changes to the coreEffort: TrivialIssues require < 1 day of workImpact: LowIssue is a papercut or has a good, supported workaround

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions