Type filtering does not respect underscores

[negasora]

Version and Platform (required):

• Binary Ninja Version: 5.2.8294-dev

Bug Description:
When filtering types, it looks like underscores are removed for matching

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

1. Go to the type sidebar
2. Filter for any type with underscores randomly inserted (like e__lf_64_s_hd_r)
3. Notice the type still gets matched (Elf64_Shdr in this example)

Expected Behavior:
Match only types that match the input

Screenshots/Video Recording:

[fuzyll]

This should be addressed in builds >= 5.3.8930-dev. Stripping the underscores was intentional in the comparison because it's very handy to have something that fuzzy-matches. The change I made was to not strip the underscores if the filter provided by the user includes one.

If we don't think that's working for people, either open a new issue or reopen this one and we can make it a setting that can be toggled instead. I tried to write the code so that would be easier to do going forward.