From faac469f6fb026ebd91e6b93169046bdd2bae320 Mon Sep 17 00:00:00 2001
From: WeiN76LQh <WeiN76LQh@github.com>
Date: Sun, 29 Dec 2024 13:45:27 +0000
Subject: [PATCH] [SharedCache] Fix uninitialized `loaded` field for mappings
 returned by `BNDSCViewGetAllImages`

---
 view/sharedcache/core/SharedCache.cpp | 11 +++++++++--
 view/sharedcache/core/SharedCache.h   |  1 +
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/view/sharedcache/core/SharedCache.cpp b/view/sharedcache/core/SharedCache.cpp
index 51e95bc6a7..d45785e877 100644
--- a/view/sharedcache/core/SharedCache.cpp
+++ b/view/sharedcache/core/SharedCache.cpp
@@ -3059,6 +3059,11 @@ std::vector<MemoryRegion> SharedCache::GetMappedRegions() const
 	return State().regionsMappedIntoMemory;
 }
 
+bool SharedCache::IsMemoryMapped(uint64_t address)
+{
+	return m_dscView->IsValidOffset(address);
+}
+
 extern "C"
 {
 	BNSharedCache* BNGetSharedCache(BNBinaryView* data)
@@ -3322,11 +3327,13 @@ extern "C"
 				images[i].mappings = (BNDSCImageMemoryMapping*)malloc(sizeof(BNDSCImageMemoryMapping) * header.sections.size());
 				for (size_t j = 0; j < header.sections.size(); j++)
 				{
+					const auto sectionStart = header.sections[j].addr;
 					images[i].mappings[j].rawViewOffset = header.sections[j].offset;
-					images[i].mappings[j].vmAddress = header.sections[j].addr;
+					images[i].mappings[j].vmAddress = sectionStart;
 					images[i].mappings[j].size = header.sections[j].size;
 					images[i].mappings[j].name = BNAllocString(header.sectionNames[j].c_str());
-					images[i].mappings[j].filePath = BNAllocString(vm->MappingAtAddress(header.sections[j].addr).first.filePath.c_str());
+					images[i].mappings[j].filePath = BNAllocString(vm->MappingAtAddress(sectionStart).first.filePath.c_str());
+					images[i].mappings[j].loaded = cache->object->IsMemoryMapped(sectionStart);
 				}
 				i++;
 			}
diff --git a/view/sharedcache/core/SharedCache.h b/view/sharedcache/core/SharedCache.h
index 8fa98c05c5..3a521894e1 100644
--- a/view/sharedcache/core/SharedCache.h
+++ b/view/sharedcache/core/SharedCache.h
@@ -581,6 +581,7 @@ namespace SharedCacheCore {
 		std::vector<std::string> GetAvailableImages();
 
 		std::vector<MemoryRegion> GetMappedRegions() const;
+		bool IsMemoryMapped(uint64_t address);
 
 		std::vector<std::pair<std::string, Ref<Symbol>>> LoadAllSymbolsAndWait();