BluetoothLEScanFilter's manufacturerData and serviceData are not arrays

[jeroen1602]

The BluetoothLEScanFilters dictionary is created from an BluetoothLEScanFilterInit but its manufacturerData and serviceData fields aren't an array.

web-bluetooth/scanning.bs

Lines 374 to 382 in f3b3187

	[Exposed=Window, SecureContext]
	interface BluetoothLEScanFilter {
	constructor(optional BluetoothLEScanFilterInit init = {});
	readonly attribute DOMString? name;
	readonly attribute DOMString? namePrefix;
	readonly attribute FrozenArray<UUID> services;
	readonly attribute BluetoothManufacturerDataFilter manufacturerData;
	readonly attribute BluetoothServiceDataFilter serviceData;
	};

In the BluetoothLEScanFilterInit dictionary that is used in the constructor they are referenced as being a sequence so when converting to an BluetoothLEScanFilters what needs to happen to the extra items in the array?

web-bluetooth/index.bs

Lines 529 to 535 in f3b3187

	dictionary BluetoothLEScanFilterInit {
	sequence<BluetoothServiceUUID> services;
	DOMString name;
	DOMString namePrefix;
	sequence<BluetoothManufacturerDataFilterInit> manufacturerData;
	sequence<BluetoothServiceDataFilterInit> serviceData;
	};

The docs seem to assume that the fields are singular and not an array.

web-bluetooth/scanning.bs

Lines 419 to 426 in f3b3187

	<li>
	Initialize <code>this.{{BluetoothLEScanFilter/manufacturerData}}</code> as
	<code>new BluetoothManufacturerDataFilter(|init|.{{BluetoothLEScanFilterInit/manufacturerData}})</code>.
	</li>
	<li>
	Initialize <code>this.{{BluetoothLEScanFilter/serviceData}}</code> as
	<code>new BluetoothServiceDataFilter(|init|.{{BluetoothLEScanFilterInit/serviceData}})</code>.
	</li>

[jeroen1602]

Just checked what chromium does. And it seems that it uses the same type for both requestLEScan and requestDevice

https://github.com/chromium/chromium/blob/203588b13d3fa2a4ad4a463823e4b574ed39c8f7/third_party/blink/renderer/modules/bluetooth/bluetooth_le_scan_options.idl#L7-L11

https://github.com/chromium/chromium/blob/203588b13d3fa2a4ad4a463823e4b574ed39c8f7/third_party/blink/renderer/modules/bluetooth/request_device_options.idl#L7-L13

[chengweih001]

Thanks for reporting this. like what you pointed out in the Chromium implementation,I suspect web-bluetooth/scanning.bs should just use BluetoothLEScanFilterInit from web-bluetooth/index.bs. We will look into this and update this when we are actively working on shipping Web Bluetooth Scanning.