[BUG] dead-code scanner false positive — reports reachable code after early return as unreachable

[Wolfvin]

Bug

codelens dead-code reports false positives on this common Python pattern:

if condition:
    return None
return {"key": "value"}  # ← flagged as unreachable — but it IS reachable when condition is False

Evidence

PR #96 (fix for issue #93) found 7 of 18 reported 'unreachable' blocks in scripts/commands/analyze.py were this pattern. The worker 'fixed' them by adding else: after the early return — which Python style guides discourage — purely to satisfy the scanner, not because the code was actually unreachable.

Root Cause

Dead-code scanner in scripts/deadcode_engine.py (or equivalent) classifies any code following a return inside an if block as unreachable, without checking that the code is in the else branch (i.e., only reachable when the if condition is False).

Expected Behaviour

if x: return early_value\nreturn normal_value should NOT be flagged as unreachable. Only code after an unconditional return (not guarded by if) should be reported.

Impact

• False positives create noise and cause workers to make unnecessary 'style' refactors
• Adds else: after early returns — an antipattern per PEP 8

[Wolfvin]

Mengerjakan issue ini -- 2026-07-01T07:24:07Z

[Wolfvin]

PR siap review

PR: #138 — fix(deadcode): false positive on early return + multi-line dict return (closes #105)
Branch: fix/issue-105-deadcode-false-positive-early-return
Summary: Fixed root cause in where multi-line (dict/list/set literals spanning multiple lines) was skipped via without resetting , causing the dict body to be falsely flagged as unreachable after a previous early return. Also reverted 8 instances of the antipattern in back to the PEP 8-friendly form — the antipattern was only introduced in PR #96 to satisfy the buggy scanner.
Tests: 14 passed (9 existing + 5 new regression tests for issue #105), 0 failed, 0 skipped