Skip to content

Commit 56254e4

Browse files
yoavfaduth
authored andcommitted
Fix popover in RTL mode by telling RTLCSS to ignore the relevent props (#7429)
1 parent 5ea93cd commit 56254e4

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

components/popover/style.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ $arrow-size: 8px;
7575
}
7676

7777
&.is-middle.is-left {
78+
/*!rtl:begin:ignore*/
7879
margin-left: -$arrow-size;
7980

8081
&:before {
@@ -92,9 +93,11 @@ $arrow-size: 8px;
9293
border-right: none;
9394
border-top-color: transparent;
9495
}
96+
/*!rtl:end:ignore*/
9597
}
9698

9799
&.is-middle.is-right {
100+
/*!rtl:begin:ignore*/
98101
margin-left: $arrow-size;
99102

100103
&:before {
@@ -112,6 +115,7 @@ $arrow-size: 8px;
112115
border-right-style: solid;
113116
border-top-color: transparent;
114117
}
118+
/*!rtl:end:ignore*/
115119
}
116120
}
117121

@@ -161,19 +165,23 @@ $arrow-size: 8px;
161165

162166
.components-popover:not(.is-mobile).is-right & {
163167
position: absolute;
168+
/*!rtl:ignore*/
164169
left: 100%;
165170
}
166171

167172
.components-popover:not(.is-mobile):not(.is-middle).is-right & {
173+
/*!rtl:ignore*/
168174
margin-left: -24px;
169175
}
170176

171177
.components-popover:not(.is-mobile).is-left & {
172178
position: absolute;
179+
/*!rtl:ignore*/
173180
right: 100%;
174181
}
175182

176183
.components-popover:not(.is-mobile):not(.is-middle).is-left & {
184+
/*!rtl:ignore*/
177185
margin-right: -24px;
178186
}
179187
}

0 commit comments

Comments
 (0)