From cfad41947ddf63b5913f0d1192003bfdbc126717 Mon Sep 17 00:00:00 2001 From: Yoav Farhi Date: Thu, 21 Jun 2018 14:17:19 +0300 Subject: [PATCH] Fix popover in RTL mode by telling RTLCSS to ignore the relevent props --- components/popover/style.scss | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/components/popover/style.scss b/components/popover/style.scss index 666abbcdf949b0..bd1f678afd3b91 100644 --- a/components/popover/style.scss +++ b/components/popover/style.scss @@ -75,6 +75,7 @@ $arrow-size: 8px; } &.is-middle.is-left { + /*!rtl:begin:ignore*/ margin-left: -$arrow-size; &:before { @@ -92,9 +93,11 @@ $arrow-size: 8px; border-right: none; border-top-color: transparent; } + /*!rtl:end:ignore*/ } &.is-middle.is-right { + /*!rtl:begin:ignore*/ margin-left: $arrow-size; &:before { @@ -112,6 +115,7 @@ $arrow-size: 8px; border-right-style: solid; border-top-color: transparent; } + /*!rtl:end:ignore*/ } } @@ -161,19 +165,23 @@ $arrow-size: 8px; .components-popover:not(.is-mobile).is-right & { position: absolute; + /*!rtl:ignore*/ left: 100%; } .components-popover:not(.is-mobile):not(.is-middle).is-right & { + /*!rtl:ignore*/ margin-left: -24px; } .components-popover:not(.is-mobile).is-left & { position: absolute; + /*!rtl:ignore*/ right: 100%; } .components-popover:not(.is-mobile):not(.is-middle).is-left & { + /*!rtl:ignore*/ margin-right: -24px; } }