Error handling initial

Author: Spatika-Ganesh

workflowai/core/client/api.py

@@ -1,3 +1,4 @@
+import json
 from typing import Any, AsyncIterator, Literal, Optional, TypeVar, Union, overload
 
 import httpx
@@ -34,7 +35,7 @@ def _client(self) -> httpx.AsyncClient:
     async def get(self, path: str, returns: type[_R], query: Union[dict[str, Any], None] = None) -> _R:
         async with self._client() as client:
             response = await client.get(path, params=query)
-            response.raise_for_status()
+            await self.raise_for_status(response)
             return TypeAdapter(returns).validate_python(response.json())
 
     @overload
@@ -55,7 +56,7 @@ async def post(
                 content=data.model_dump_json(exclude_none=True),
                 headers={"Content-Type": "application/json"},
             )
-            response.raise_for_status()
+            await self.raise_for_status(response)
             if not returns:
                 return None
             return TypeAdapter(returns).validate_python(response.json())
@@ -78,18 +79,22 @@ async def patch(
                 content=data.model_dump_json(exclude_none=True),
                 headers={"Content-Type": "application/json"},
             )
-            response.raise_for_status()
+            await self.raise_for_status(response)
             if not returns:
                 return None
             return TypeAdapter(returns).validate_python(response.json())
 
     async def delete(self, path: str) -> None:
         async with self._client() as client:
             response = await client.delete(path)
-            response.raise_for_status()
+            await self.raise_for_status(response)
 
     def _extract_error(self, data: Union[bytes, str], exception: Optional[Exception] = None) -> WorkflowAIError:
         try:
+            data_dict = json.loads(data)
+            if next(iter(data_dict.keys())) == "detail":
+                data_dict = {"error": {"detail": data_dict["detail"]}}
+                data = json.dumps(data_dict)
             res = ErrorResponse.model_validate_json(data)
             return WorkflowAIError(res.error, task_run_id=res.task_run_id)
         except ValidationError:
@@ -122,3 +127,7 @@ async def stream(
                         yield returns.model_validate_json(payload)
                 except ValidationError as e:
                     raise self._extract_error(payload, e) from None
+
+    async def raise_for_status(self, response: httpx.Response):
+        if response.status_code != 200:
+            raise self._extract_error(response.content) from None

workflowai/core/domain/errors.py

@@ -1,3 +1,4 @@
+import json
 from typing import Any, Literal, Optional, Union
 
 from pydantic import BaseModel
@@ -71,3 +72,13 @@ class WorkflowAIError(Exception):
     def __init__(self, error: BaseError, task_run_id: Optional[str] = None):
         self.error = error
         self.task_run_id = task_run_id
+
+    def __str__(self):
+        error_dict = {
+            "message": self.error.message,
+            "code": self.error.code,
+            "status_code": self.error.status_code,
+            "details": self.error.details,
+            "task_run_id": self.task_run_id,
+        }
+        return json.dumps(error_dict, indent=4)