From e91b337a95e0d20aea540b3eba4662f49e2336a6 Mon Sep 17 00:00:00 2001 From: Liang-Ta Wei Date: Tue, 10 Jun 2025 01:59:59 -0600 Subject: [PATCH] chore: remove warning for inexact result --- mlir/lib/Dialect/PDL/IR/Builtins.cpp | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/mlir/lib/Dialect/PDL/IR/Builtins.cpp b/mlir/lib/Dialect/PDL/IR/Builtins.cpp index bc238092c141d..313c855fe39e8 100644 --- a/mlir/lib/Dialect/PDL/IR/Builtins.cpp +++ b/mlir/lib/Dialect/PDL/IR/Builtins.cpp @@ -274,15 +274,11 @@ LogicalResult static binaryOp(PatternRewriter &rewriter, PDLResultList &results, "encounter an unsupported binary operator."); } - if (operationStatus != APFloat::opOK) { - if (operationStatus != APFloat::opInexact) - return failure(); - - emitWarning(rewriter.getUnknownLoc()) - << "Binary arithmetic operation between " << lhsVal.convertToFloat() - << " and " << rhsVal.convertToFloat() - << " produced an inexact result"; + if (operationStatus != APFloat::opOK && + operationStatus != APFloat::opInexact) { + return failure(); } + results.push_back(rewriter.getFloatAttr(floatType, resultVal)); return success(); }