From c4f8da94a143b954de975091b3ec563bb01b0837 Mon Sep 17 00:00:00 2001
From: Matthias Gehre <matthias.gehre@amd.com>
Date: Wed, 19 Feb 2025 08:46:53 +0100
Subject: [PATCH 1/2] [MLIR][emitc]: Remove unused functions (NFC)

---
 mlir/lib/Dialect/EmitC/IR/EmitC.cpp | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/mlir/lib/Dialect/EmitC/IR/EmitC.cpp b/mlir/lib/Dialect/EmitC/IR/EmitC.cpp
index 1e8952a7edf4e..eb7ffe2e032c4 100644
--- a/mlir/lib/Dialect/EmitC/IR/EmitC.cpp
+++ b/mlir/lib/Dialect/EmitC/IR/EmitC.cpp
@@ -991,27 +991,6 @@ LogicalResult emitc::VerbatimOp::verify() {
   return success();
 }
 
-[[maybe_unused]] static ParseResult
-parseVariadicTypeFmtArgs(AsmParser &p, SmallVector<Type> &params) {
-  Type type;
-  if (p.parseType(type))
-    return failure();
-
-  params.push_back(type);
-  while (succeeded(p.parseOptionalComma())) {
-    if (p.parseType(type))
-      return failure();
-    params.push_back(type);
-  }
-
-  return success();
-}
-
-[[maybe_unused]] static void printVariadicTypeFmtArgs(AsmPrinter &p,
-                                                      ArrayRef<Type> params) {
-  llvm::interleaveComma(params, p, [&](Type type) { p.printType(type); });
-}
-
 FailureOr<SmallVector<ReplacementItem>> emitc::VerbatimOp::parseFormatString() {
   // Error checking is done in verify.
   return ::parseFormatString(getValue(), getFmtArgs());

From d35535f5204c337acc8e697d79bb6623d373b847 Mon Sep 17 00:00:00 2001
From: Jonas Rickert <jonas.rickert@amd.com>
Date: Wed, 18 Jun 2025 02:16:52 -0600
Subject: [PATCH 2/2] Revert "[MLIR][emitc]: Remove unused functions (NFC)"

This reverts commit c4f8da94a143b954de975091b3ec563bb01b0837.
---
 mlir/lib/Dialect/EmitC/IR/EmitC.cpp | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/mlir/lib/Dialect/EmitC/IR/EmitC.cpp b/mlir/lib/Dialect/EmitC/IR/EmitC.cpp
index c92c23cbc6448..1680d521d919f 100644
--- a/mlir/lib/Dialect/EmitC/IR/EmitC.cpp
+++ b/mlir/lib/Dialect/EmitC/IR/EmitC.cpp
@@ -1043,6 +1043,27 @@ LogicalResult emitc::VerbatimOp::verify() {
   return success();
 }
 
+[[maybe_unused]] static ParseResult
+parseVariadicTypeFmtArgs(AsmParser &p, SmallVector<Type> &params) {
+  Type type;
+  if (p.parseType(type))
+    return failure();
+
+  params.push_back(type);
+  while (succeeded(p.parseOptionalComma())) {
+    if (p.parseType(type))
+      return failure();
+    params.push_back(type);
+  }
+
+  return success();
+}
+
+[[maybe_unused]] static void printVariadicTypeFmtArgs(AsmPrinter &p,
+                                                      ArrayRef<Type> params) {
+  llvm::interleaveComma(params, p, [&](Type type) { p.printType(type); });
+}
+
 FailureOr<SmallVector<ReplacementItem>> emitc::VerbatimOp::parseFormatString() {
   // Error checking is done in verify.
   return ::parseFormatString(getValue(), getFmtArgs());