Skip to content

Error with boolean variables #18

Description

@thiagoalmeidasa

Hi, first of all, congrats for this job.

I don't know how do you use boolean variables from docker-compose because in my tries these variables are converted from boolean to string.

Example:

---
docker-compose
PROD_MAIL_SECURE_CONNECTION: 'false'

And then, inside the container:

> typeof(process.env['PROD_MAIL_SECURE_CONNECTION'])
'string'

To work around this problem, I have edited the config.js file to use JSON.parse in specific variables, but I think the CheckEnvVar function could be improved testing for true or false strings, and then convert the value, like in http://stackoverflow.com/questions/3976714/converting-string-true-false-to-boolean-value

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions