Skip to content

Commit 5d2f421

Browse files
committed
fix: do not ignore advisory_id while deserializing AdvisoryDataV2 from dict
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
1 parent 30b3ef6 commit 5d2f421

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

vulnerabilities/importer.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -648,6 +648,7 @@ def to_dict(self):
648648
def from_dict(cls, advisory_data):
649649
date_published = advisory_data["date_published"]
650650
transformed = {
651+
"advisory_id": advisory_data["advisory_id"],
651652
"aliases": advisory_data["aliases"],
652653
"summary": advisory_data["summary"],
653654
"affected_packages": [

vulnerabilities/tests/test_utils.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,3 +254,10 @@ def test_content_id_from_adv_data_and_adv_model_are_same(self):
254254
id_from_model = utils.compute_content_id_v2(advisory_model)
255255

256256
self.assertEqual(id_from_data, id_from_model)
257+
258+
def test_content_id_from_adv_data_roundtrip_are_same(self):
259+
id_from_data = utils.compute_content_id_v2(self.advisory1)
260+
adv_roundtrip = AdvisoryDataV2.from_dict(self.advisory1.to_dict())
261+
id_from_roundtrip = utils.compute_content_id_v2(adv_roundtrip)
262+
263+
self.assertEqual(id_from_data, id_from_roundtrip)

0 commit comments

Comments
 (0)