feat: Implement hierarchical UI inspection#2
Conversation
- Add `get_ui_tree_hierarchical` to `sid/utils/ui.py` to retrieve raw nested UI tree. - Add `simplify_node` helper in `sid/commands/vision.py` to recursively simplify the tree structure while preserving hierarchy. - Update `inspect_cmd` to default to hierarchical output. - Add `--flat` flag to `inspect` command for backward compatibility. - Update `SPEC.md` documentation. - Add tests for hierarchical inspection and simplify logic. - Fix `test_logs_crash_report` environment issue. Co-authored-by: acrollet <101649+acrollet@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Rename `sid` directory to `pippin`. - Update `pyproject.toml`, `README.md`, `SPEC.md`, and documentation to reflect the name change. - Update all Python imports and references from `sid` to `pippin`. - Add `get_ui_tree_hierarchical` to `pippin/utils/ui.py`. - Add `simplify_node` helper in `pippin/commands/vision.py` for hierarchical output. - Update `inspect_cmd` to default to hierarchical output, adding `--flat` flag for backward compatibility. - Add tests for hierarchical inspection and verify rename integrity. Co-authored-by: acrollet <101649+acrollet@users.noreply.github.com>
1 participant
Implemented hierarchical UI inspection as described in docs/improvements/01-hierarchy.md.
The
inspectcommand now returns a nested JSON structure by default, preserving parent-child relationships which helps LLMs understand the UI context better.Added
--flatflag to support the previous flat list output.Updated documentation and added tests.
PR created automatically by Jules for task 689866059070890510 started by @acrollet