Commit d448b13
committed
Tighten rubric and Lessons Learned from the contract-driven audit pass
Two docs updates capture what shipped over the last set of commits.
docs/example-figure-rubric.md — Release Gates section expanded with
the contract-backed hard gates that didn't exist (or were softer)
in v2:
* No clipping (Contract 1) — text width counts, not just baseline.
* No element collision (Contract 2) — text in a rect must be
fully contained by that rect, not partly overlapping the box
above it.
* No text-text overlap (Contract 3) — narrow object_boxes whose
tag+value compete for horizontal space are caught.
* Caption uniqueness across slugs (Contract 5b) — reused figures
need bespoke captions per attachment.
* Palette, font, and stroke-weight discipline (Contract 5a-c) —
locked at the grammar; CI catches drift.
* Emphasis scarcity, ENFORCED (Contract 9) — was soft v1, now
hard. At most one accent per figure.
* Banner-fit (Contract 8) — every figure's intrinsic width fits
the 440px cell-banner--1 ceiling.
* Twin consistency — when two figures depict parallel concepts,
their coordinates must match coordinate-for-coordinate where
the concepts coincide. A single-pixel drift in one breaks the
visual rhyme.
* Geometric termination — lines must land at element edges, not
1-2px short or inside the glyph.
* Mono character alignment — vertical dividers marking positions
in mono text must use the font's actual advance (~6px per char
at fs=10), not eyeballed pixels.
* Gestalt = production — review pages render the same paint code
as production attachments; parallel paint code drifts and
hides bugs.
docs/lessons-learned.md — 10 new lessons added to the
"Visualisations and marginalia" section, each captured from a real
bug class we shipped a contract for:
- audits without contracts rot
- clipping ≠ collision; padding fixes one not the other
- heuristic audits over-flag; trust the design, not the regex
- structural twins must share coordinates exactly
- reused figure → bespoke caption per slug
- one paint registry, not two
- tag-above vs tag-inside is a layout decision driven by stacking
- mono character alignment uses the font's advance
- lines must terminate AT elements
- journey pages don't yet render section figures inline (open
design question)
Tests: 54 still green; no production code changed.1 parent 945c37b commit d448b13
2 files changed
Lines changed: 62 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
102 | 108 | | |
103 | 109 | | |
104 | 110 | | |
| |||
108 | 114 | | |
109 | 115 | | |
110 | 116 | | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
111 | 133 | | |
112 | | - | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
113 | 160 | | |
114 | 161 | | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
115 | 166 | | |
116 | 167 | | |
117 | 168 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
0 commit comments