Skip to content

[Robustness] HistoryResult.cs — Lines property exposes mutable List<LogLine> #675

@Christophe-Rogiers

Description

@Christophe-Rogiers

Severity: Warning

File: src/Servy.Manager/Utils/HistoryResult.cs
Line: 14

Description:
public List<LogLine> Lines { get; } has no setter but List<LogLine> is mutable. Any caller can call Lines.Add(...), Lines.Clear(), etc., corrupting the result for other consumers.

Suggested fix:
Change to IReadOnlyList<LogLine>.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions