Severity: Warning
Files:
src/Servy.Core/Services/JsonServiceSerializer.cssrc/Servy.Core/Services/XmlServiceSerializer.cs
Description:
Deserialize() does not catch JsonException/XmlException from the underlying deserializer. The interface contract does not document that callers must handle deserialization exceptions. This is inconsistent: JsonServiceValidator.TryValidate wraps the same call in try/catch, but the serializer does not.
Suggested fix:
Either catch and return null (matching the "returns null on failure" pattern used elsewhere), or document in the interface that callers must handle deserialization exceptions.
Severity: Warning
Files:
src/Servy.Core/Services/JsonServiceSerializer.cssrc/Servy.Core/Services/XmlServiceSerializer.csDescription:
Deserialize()does not catchJsonException/XmlExceptionfrom the underlying deserializer. The interface contract does not document that callers must handle deserialization exceptions. This is inconsistent:JsonServiceValidator.TryValidatewraps the same call in try/catch, but the serializer does not.Suggested fix:
Either catch and return null (matching the "returns null on failure" pattern used elsewhere), or document in the interface that callers must handle deserialization exceptions.