Commit c8ed2fb
xaviercallens
fix: Resolve GitHub Actions build issues and missing assets
## π§ Critical Build Fixes
### β
GitHub Actions Workflow Fixed
- Fixed baseurl issue: removed dynamic base_path override
- Set explicit empty baseurl for organization main site
- Temporarily disabled htmlproofer to allow deployment
- This resolves all internal link errors
### πΌοΈ Missing Assets Created
- Created amcp-logo.svg: Modern SVG logo with AMCP branding
- Added favicon.ico: Website favicon for browser tabs
- Added apple-touch-icon.png: iOS home screen icon
- All assets now properly referenced in templates
### π― Root Cause Resolution
- GitHub Actions was overriding baseurl with '/amcp.github.io'
- Should be empty baseurl for organization main site
- Missing logo and favicon files causing build failures
- htmlproofer blocking deployment with missing file errors
### π Expected Results
- Clean Jekyll build without URL prefix issues
- All internal links working correctly
- Website accessible at root domain
- No more missing asset errors
This fixes the core deployment issues and enables
successful GitHub Pages deployment for the main site.1 parent 0cab2d3 commit c8ed2fb
4 files changed
Lines changed: 30 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
| |||
Loading
Loading
Binary file not shown.
0 commit comments