From 4817131bc5a895e4edc9d7c66b6727043a140a29 Mon Sep 17 00:00:00 2001
From: "Optimus (AI Agent)" <agent@fulcria.com>
Date: Thu, 5 Mar 2026 20:41:04 +0000
Subject: [PATCH] fix: rename kubernetes-default provider ID to kubernetes

Simplifies the provider ID by removing the unnecessary "-default" suffix.
Adds migration 010 to rename existing provider records and update
deployment references.

Closes #258

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 e2e/deploy_test.go                                 |  4 ++--
 internal/cli/agent/deploy.go                       |  2 +-
 .../api/handlers/v0/deployment_adapters.go         |  2 +-
 .../registry/api/handlers/v0/providers_test.go     |  4 ++--
 .../010_rename_kubernetes_default_provider.sql     | 14 ++++++++++++++
 internal/registry/service/registry_service.go      |  2 +-
 6 files changed, 21 insertions(+), 7 deletions(-)
 create mode 100644 internal/registry/database/migrations/010_rename_kubernetes_default_provider.sql

diff --git a/e2e/deploy_test.go b/e2e/deploy_test.go
index fc6dfadf..285bf7a0 100644
--- a/e2e/deploy_test.go
+++ b/e2e/deploy_test.go
@@ -38,7 +38,7 @@ var agentDeployTargets = []deployTarget{
 	},
 	{
 		name:     "kubernetes",
-		deplArgs: []string{"--provider-id", "kubernetes-default", "--namespace", "default"},
+		deplArgs: []string{"--provider-id", "kubernetes", "--namespace", "default"},
 		cleanup: func(t *testing.T, agentName string) {
 			ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
 			defer cancel()
@@ -65,7 +65,7 @@ var mcpDeployTargets = []deployTarget{
 	},
 	{
 		name:     "kubernetes",
-		deplArgs: []string{"--provider-id", "kubernetes-default", "--namespace", "default"},
+		deplArgs: []string{"--provider-id", "kubernetes", "--namespace", "default"},
 		cleanup: func(t *testing.T, mcpName string) {
 			ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
 			defer cancel()
diff --git a/internal/cli/agent/deploy.go b/internal/cli/agent/deploy.go
index 341b88bc..b0c7f245 100644
--- a/internal/cli/agent/deploy.go
+++ b/internal/cli/agent/deploy.go
@@ -17,7 +17,7 @@ var DeployCmd = &cobra.Command{
 Example:
   arctl agent deploy my-agent --version latest
   arctl agent deploy my-agent --version 1.2.3
-  arctl agent deploy my-agent --version latest --provider-id kubernetes-default`,
+  arctl agent deploy my-agent --version latest --provider-id kubernetes`,
 	Args: cobra.ExactArgs(1),
 	RunE: runDeploy,
 }
diff --git a/internal/registry/api/handlers/v0/deployment_adapters.go b/internal/registry/api/handlers/v0/deployment_adapters.go
index 33cd6808..adee03fb 100644
--- a/internal/registry/api/handlers/v0/deployment_adapters.go
+++ b/internal/registry/api/handlers/v0/deployment_adapters.go
@@ -88,7 +88,7 @@ func (a *kubernetesDeploymentAdapter) Deploy(ctx context.Context, req *models.De
 	}
 	providerID := req.ProviderID
 	if providerID == "" {
-		providerID = "kubernetes-default"
+		providerID = "kubernetes"
 	}
 	env := req.Env
 	if env == nil {
diff --git a/internal/registry/api/handlers/v0/providers_test.go b/internal/registry/api/handlers/v0/providers_test.go
index f70e4528..a4f48af4 100644
--- a/internal/registry/api/handlers/v0/providers_test.go
+++ b/internal/registry/api/handlers/v0/providers_test.go
@@ -161,7 +161,7 @@ func TestListProviders_WithData(t *testing.T) {
 	k8sAdapter := &fakeProviderAdapter{
 		platform: "kubernetes",
 		providers: map[string]*models.Provider{
-			"kubernetes-default": {ID: "kubernetes-default", Name: "Kubernetes Default", Platform: "kubernetes"},
+			"kubernetes": {ID: "kubernetes", Name: "Kubernetes Default", Platform: "kubernetes"},
 		},
 	}
 	v0.RegisterProvidersEndpoints(api, "/v0", fake, v0.PlatformExtensions{
@@ -178,7 +178,7 @@ func TestListProviders_WithData(t *testing.T) {
 	assert.Equal(t, http.StatusOK, w.Code)
 	assert.Contains(t, w.Body.String(), `"id":"local"`)
 	assert.Contains(t, w.Body.String(), `"platform":"local"`)
-	assert.Contains(t, w.Body.String(), `"id":"kubernetes-default"`)
+	assert.Contains(t, w.Body.String(), `"id":"kubernetes"`)
 	assert.Contains(t, w.Body.String(), `"platform":"kubernetes"`)
 }
 
diff --git a/internal/registry/database/migrations/010_rename_kubernetes_default_provider.sql b/internal/registry/database/migrations/010_rename_kubernetes_default_provider.sql
new file mode 100644
index 00000000..28bebd12
--- /dev/null
+++ b/internal/registry/database/migrations/010_rename_kubernetes_default_provider.sql
@@ -0,0 +1,14 @@
+-- Rename the kubernetes-default provider ID to kubernetes for consistency.
+
+-- Insert the new provider if it doesn't exist yet.
+INSERT INTO providers (id, name, platform, config)
+VALUES ('kubernetes', 'Kubernetes', 'kubernetes', '{}'::jsonb)
+ON CONFLICT (id) DO NOTHING;
+
+-- Migrate any deployments referencing the old ID.
+UPDATE deployments
+SET provider_id = 'kubernetes'
+WHERE provider_id = 'kubernetes-default';
+
+-- Remove the old provider.
+DELETE FROM providers WHERE id = 'kubernetes-default';
diff --git a/internal/registry/service/registry_service.go b/internal/registry/service/registry_service.go
index 7ed7bf2f..91fd6ba1 100644
--- a/internal/registry/service/registry_service.go
+++ b/internal/registry/service/registry_service.go
@@ -31,7 +31,7 @@ const (
 	maxServerVersionsPerServer = 10000
 
 	localProviderID      = "local"
-	kubernetesProviderID = "kubernetes-default"
+	kubernetesProviderID = "kubernetes"
 	platformLocal        = "local"
 	platformKubernetes   = "kubernetes"
 	resourceTypeMCP      = "mcp"