feat(cli): add arctl status command#276
feat(cli): add arctl status command#276optimus-fulcria wants to merge 5 commits intoagentregistry-dev:mainfrom
arctl status command#276Conversation
peterj
left a comment
There was a problem hiding this comment.
The status command shouldn't try to start the registry daemon:
arctl status
Starting agentregistry daemon...
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
|
Fixed - |
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
|
are you testing your changes manually too? Please do test them manually. If the server is down, I see this: I would expect to see something like this when server is down: |
|
Fixed in 0fec19a: the status command now checks for the daemon without auto-starting it. If the daemon isn't running, it reports that rather than launching it. |
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
5 similar comments
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
|
@peterj This is addressed — the |
|
The daemon auto-start issue is fixed — commit |
Add a read-only status command that reports the current state of the daemon, database connectivity, server version, and registry resource counts without attempting to start or modify the daemon. The command is added to skipCommands in preRunDaemonBehavior so PersistentPreRunE is skipped entirely - no daemon auto-start, no client initialization. The status command creates its own lightweight client only when the daemon is already reachable. When the daemon is not running the output is: arctl version <version> x Daemon is not running (http://localhost:12121/v0) x Database is not reachable Registry resources: could not retrieve resources Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
…tus to reflect this Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
| pathPrefix := "/v0" | ||
|
|
||
| v0.RegisterHealthEndpoint(api, pathPrefix, cfg, metrics) | ||
| v0.RegisterHealthEndpoint(api, pathPrefix, cfg, metrics, registry) |
There was a problem hiding this comment.
note: passing registry so it does registry.db.PingDB() for db health
|
You already have 3 pull requests open. Please consider working on getting the existing ones merged before opening new ones. Thanks! |
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
21442db to
b2fe022
Compare
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Description
Add an
arctl statuscommand that shows the current state of the registry daemon and running agents/servers.What changed:
arctl statuscommand showing daemon status, registry URL, and deployment countsPingfunctionality to resolve database connection statushealthcheck under newdatabasefield.printerpkg which outputs to stdout, so no way of capturing this.Validation
Change Type
/kind feature
Changelog