chore: replace fake reason codes in tests with real API codes

Tests used invented reason strings like \`not_kyc\`, \`score_too_low\`,
\`sanctions_check_pending\` that don't exist in the API surface (the real
codes are \`kyc_required\`, \`kyc_pending\`, \`kyc_failed\`, \`sanctions_flagged\`,
\`age_insufficient\`, \`jurisdiction_restricted\`). Tests pass either way (the
gate passes reasons through verbatim), but the fake strings propagate
misinformation. Replace with real codes for documentation accuracy.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: vvillait88

tests/test_aiohttp.py

@@ -78,14 +78,14 @@ async def handler(request: web.Request) -> web.Response:
     @pytest.mark.asyncio
     @respx.mock
     async def test_denies_untrusted_wallet(self):
-        _mock_assess("deny", reasons=["not_kyc"])
+        _mock_assess("deny", reasons=["kyc_required"])
         client = await _client(_make_app())
         async with client:
             resp = await client.get("/", headers={"X-Wallet-Address": "0xabc"})
             assert resp.status == 403
             data = await resp.json()
             assert data["error"]["code"] == "wallet_not_trusted"
-            assert data["reasons"] == ["not_kyc"]
+            assert data["reasons"] == ["kyc_required"]
 
     @pytest.mark.asyncio
     async def test_missing_identity_returns_403(self):

tests/test_client.py

@@ -394,7 +394,7 @@ def test_full_compliance_deny_flow(self):
         """Integration test: full middleware flow with compliance deny."""
         compliance_response = {
             "decision": "deny",
-            "decision_reasons": ["kyc_required", "sanctions_check_pending"],
+            "decision_reasons": ["kyc_required", "sanctions_flagged"],
             "score": {"value": 72, "grade": "C", "status": "scored"},
             "operator_verification": {
                 "level": "none",
@@ -424,7 +424,7 @@ def test_full_compliance_deny_flow(self):
         assert result.allow is False
         assert result.decision == "deny"
         assert "kyc_required" in result.reasons
-        assert "sanctions_check_pending" in result.reasons
+        assert "sanctions_flagged" in result.reasons
         assert result.verify_url == "https://agentscore.sh/verify/xyz789"
         assert result.operator_verification is not None
         assert result.operator_verification.level == "none"

tests/test_django.py

@@ -61,7 +61,7 @@ def test_allows_trusted_wallet(self) -> None:
 
     def test_blocks_untrusted_wallet(self) -> None:
         mw = self._make_middleware()
-        result = AssessResult(allow=False, decision="deny", reasons=["score_too_low"], raw={})
+        result = AssessResult(allow=False, decision="deny", reasons=["kyc_required"], raw={})
         request = self.factory.get("/", HTTP_X_WALLET_ADDRESS="0xabc")
         with patch("agentscore_commerce.identity.django.GateClient.check", return_value=result):
             resp = mw(request)
@@ -178,7 +178,7 @@ def test_deny_includes_reasons_from_compliance(self) -> None:
         result = AssessResult(
             allow=False,
             decision="deny",
-            reasons=["kyc_required", "sanctions_check_pending"],
+            reasons=["kyc_required", "sanctions_flagged"],
             raw={
                 "verify_url": "https://agentscore.sh/verify/abc123",
                 "operator_verification": {"level": "none"},
@@ -191,7 +191,7 @@ def test_deny_includes_reasons_from_compliance(self) -> None:
             data = json.loads(resp.content)
             assert data["error"]["code"] == "wallet_not_trusted"
             assert "kyc_required" in data["reasons"]
-            assert "sanctions_check_pending" in data["reasons"]
+            assert "sanctions_flagged" in data["reasons"]
 
     def test_allow_with_operator_verification_attaches_to_request(self) -> None:
         mw = self._make_middleware()

tests/test_fastapi.py

@@ -57,15 +57,15 @@ def test_allows_trusted_wallet(self):
 
     @respx.mock
     def test_denies_untrusted_wallet(self):
-        _mock_assess("deny", reasons=["not_kyc"])
+        _mock_assess("deny", reasons=["kyc_required"])
         gate = AgentScoreGate(api_key="ask_test")
         client = TestClient(_make_app(gate))
         resp = client.get("/", headers={"X-Wallet-Address": "0xabc"})
         assert resp.status_code == 403
         body = resp.json()
         # FastAPI wraps HTTPException detail in {"detail": {...}}.
         assert body["detail"]["error"]["code"] == "wallet_not_trusted"
-        assert body["detail"]["reasons"] == ["not_kyc"]
+        assert body["detail"]["reasons"] == ["kyc_required"]
 
     def test_missing_identity_returns_403(self):
         gate = AgentScoreGate(api_key="ask_test")

tests/test_flask.py

@@ -64,7 +64,7 @@ def test_get_assess_data_returns_none_outside_request(self) -> None:
 
     def test_blocks_untrusted_wallet(self) -> None:
         app = _make_app()
-        result = AssessResult(allow=False, decision="deny", reasons=["score_too_low"], raw={})
+        result = AssessResult(allow=False, decision="deny", reasons=["kyc_required"], raw={})
         with patch("agentscore_commerce.identity.flask.GateClient.check", return_value=result):
             client = app.test_client()
             resp = client.get("/", headers={"x-wallet-address": "0xabc"})
@@ -176,7 +176,7 @@ def test_deny_includes_compliance_reasons(self) -> None:
         result = AssessResult(
             allow=False,
             decision="deny",
-            reasons=["kyc_required", "sanctions_check_pending"],
+            reasons=["kyc_required", "sanctions_flagged"],
             raw={
                 "verify_url": "https://agentscore.sh/verify/abc123",
                 "operator_verification": {"level": "none"},
@@ -189,7 +189,7 @@ def test_deny_includes_compliance_reasons(self) -> None:
             data = resp.get_json()
             assert data["error"]["code"] == "wallet_not_trusted"
             assert "kyc_required" in data["reasons"]
-            assert "sanctions_check_pending" in data["reasons"]
+            assert "sanctions_flagged" in data["reasons"]
 
     def test_allow_with_operator_verification_attaches_to_g(self) -> None:
         app = _make_app()

tests/test_sanic.py

@@ -21,7 +21,7 @@ def _allow_result() -> AssessResult:
 
 
 def _deny_result() -> AssessResult:
-    return AssessResult(allow=False, decision="deny", reasons=["not_kyc"])
+    return AssessResult(allow=False, decision="deny", reasons=["kyc_required"])
 
 
 def _make_app(name: str, **gate_kwargs) -> Sanic:
@@ -78,7 +78,7 @@ def test_denies_untrusted_wallet(self):
             _, resp = app.test_client.get("/", headers={"X-Wallet-Address": "0xabc"})
         assert resp.status == 403
         assert resp.json["error"]["code"] == "wallet_not_trusted"
-        assert resp.json["reasons"] == ["not_kyc"]
+        assert resp.json["reasons"] == ["kyc_required"]
 
     def test_missing_identity_returns_403(self):
         app = _make_app("sanic_missing")