style: conform to SonarQube quality gate

Author: olivermeyer

tests/aignostics_foundry_core/database_test.py

@@ -47,6 +47,11 @@ async def test_get_db_session_raises_before_init(self) -> None:
             await anext(gen)
 
 
+async def noop(**_kwargs: object) -> None:
+    """A no-op async function that accepts arbitrary keyword arguments."""
+    await asyncio.sleep(0)
+
+
 class TestInitEngine:
     """Tests for init_engine and dispose_engine lifecycle."""
 
@@ -61,10 +66,6 @@ async def test_init_engine_is_idempotent(self, sqlite_url: str) -> None:
         """Calling init_engine twice is a no-op — execute_with_session works after both calls."""
         init_engine(sqlite_url)
         init_engine(sqlite_url)  # Must not raise; second call is a silent no-op
-
-        async def noop(**_kwargs: object) -> None:
-            pass
-
         await execute_with_session(noop)  # Session maker still functional
 
     @pytest.mark.unit
@@ -82,7 +83,8 @@ async def test_execute_with_session_passes_session(self, sqlite_url: str) -> Non
         """The wrapped function receives an AsyncSession as the 'session' keyword argument."""
         received: list[object] = []
 
-        async def capture_session(**kwargs: object) -> None:  # noqa: RUF029
+        async def capture_session(**kwargs: object) -> None:
+            await asyncio.sleep(0)  # Use an asynchronous feature
             received.append(kwargs.get(SESSION_KWARG))
 
         init_engine(sqlite_url)
@@ -94,10 +96,6 @@ async def capture_session(**kwargs: object) -> None:  # noqa: RUF029
     @pytest.mark.unit
     async def test_execute_with_session_raises_before_init(self) -> None:
         """RuntimeError raised when execute_with_session is called before init_engine."""
-
-        async def noop(**_: object) -> None:
-            pass
-
         with pytest.raises(RuntimeError, match="not initialized"):
             await execute_with_session(noop)
 
@@ -109,7 +107,8 @@ class TestCliRunWithDb:
     async def test_cli_run_with_db_returns_function_result(self, sqlite_url: str) -> None:
         """cli_run_with_db returns the value produced by the async function."""
 
-        async def return_42(**_: object) -> int:  # noqa: RUF029
+        async def return_42(**_: object) -> int:
+            await asyncio.sleep(0)  # Use an asynchronous feature
             return 42
 
         result = await asyncio.to_thread(cli_run_with_db, return_42, db_url=sqlite_url)
@@ -127,10 +126,6 @@ async def raise_error(**_: object) -> None:  # noqa: RUF029
         with pytest.raises(ValueError, match=err_msg):
             await asyncio.to_thread(cli_run_with_db, raise_error, db_url=sqlite_url)
 
-        # Engine was cleaned up; init_engine followed by execute_with_session must work.
-        async def noop(**_: object) -> None:
-            pass
-
         init_engine(sqlite_url)
         await execute_with_session(noop)
 
@@ -142,7 +137,8 @@ class TestCliRunWithEngine:
     async def test_cli_run_with_engine_executes_function(self, sqlite_url: str) -> None:
         """cli_run_with_engine returns the value produced by the async function."""
 
-        async def return_hello() -> str:  # noqa: RUF029
+        async def return_hello() -> str:
+            await asyncio.sleep(0)  # Use an asynchronous feature
             return "hello"
 
         result = await asyncio.to_thread(cli_run_with_engine, return_hello, db_url=sqlite_url)
@@ -160,10 +156,6 @@ async def raise_error() -> None:  # noqa: RUF029
         with pytest.raises(ValueError, match=err_msg):
             await asyncio.to_thread(cli_run_with_engine, raise_error, db_url=sqlite_url)
 
-        # Engine was cleaned up; init_engine followed by execute_with_session must work.
-        async def noop(**_: object) -> None:
-            pass
-
         init_engine(sqlite_url)
         await execute_with_session(noop)
 

tests/aignostics_foundry_core/sentry_test.py

@@ -11,6 +11,8 @@
 _PROJECT = "testproject"
 _VERSION = "1.0.0"
 _ENVIRONMENT = "test"
+_SENTRY_SET_USER = "sentry_sdk.set_user"
+_AUTH0_USER = "auth0|x"
 
 
 @pytest.mark.unit
@@ -133,37 +135,37 @@ class TestSetSentryUser:
     def test_set_sentry_user_maps_sub_to_id(self) -> None:
         """set_sentry_user maps 'sub' claim to 'id' in Sentry user context."""
         mock_set_user = MagicMock()
-        with patch("sentry_sdk.set_user", mock_set_user):
-            set_sentry_user({"sub": "auth0|x"})
-        mock_set_user.assert_called_once_with({"id": "auth0|x"})
+        with patch(_SENTRY_SET_USER, mock_set_user):
+            set_sentry_user({"sub": _AUTH0_USER})
+        mock_set_user.assert_called_once_with({"id": _AUTH0_USER})
 
     def test_set_sentry_user_none_clears_context(self) -> None:
         """set_sentry_user(None) calls sentry_sdk.set_user(None) to clear context."""
         mock_set_user = MagicMock()
-        with patch("sentry_sdk.set_user", mock_set_user):
+        with patch(_SENTRY_SET_USER, mock_set_user):
             set_sentry_user(None)
         mock_set_user.assert_called_once_with(None)
 
     def test_set_sentry_user_does_nothing_when_sdk_absent(self) -> None:
         """set_sentry_user is a no-op when sentry_sdk is not importable."""
         with patch("aignostics_foundry_core.sentry.find_spec", return_value=None):
             # Should not raise even though sentry_sdk is unavailable
-            set_sentry_user({"sub": "auth0|x"})
+            set_sentry_user({"sub": _AUTH0_USER})
 
     def test_set_sentry_user_includes_role_from_claim(self) -> None:
         """set_sentry_user includes role from a custom claim when role_claim is provided."""
         mock_set_user = MagicMock()
-        with patch("sentry_sdk.set_user", mock_set_user):
+        with patch(_SENTRY_SET_USER, mock_set_user):
             set_sentry_user(
-                {"sub": "auth0|x", "https://my/role": "admin"},
+                {"sub": _AUTH0_USER, "https://my/role": "admin"},
                 role_claim="https://my/role",
             )
         assert mock_set_user.call_args[0][0]["role"] == "admin"
 
     def test_set_sentry_user_maps_multiple_fields(self) -> None:
         """set_sentry_user maps all standard Auth0 fields to Sentry user context."""
         mock_set_user = MagicMock()
-        with patch("sentry_sdk.set_user", mock_set_user):
+        with patch(_SENTRY_SET_USER, mock_set_user):
             set_sentry_user({
                 "sub": "auth0|abc",
                 "email": "user@example.com",