-
Notifications
You must be signed in to change notification settings - Fork 0
feat: portfolio rollup helper for category-level reporting #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ak684
wants to merge
2
commits into
main
Choose a base branch
from
feat/investment-rollup-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
100 changes: 100 additions & 0 deletions
100
src/main/java/io/ventureplatform/util/InvestmentRollup.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| package io.ventureplatform.util; | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.Objects; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| /** | ||
| * Aggregates investment data across portfolio companies | ||
| * for dashboard rollups. | ||
| * | ||
| * <p>Used by reporting endpoints to compute category-level | ||
| * totals and rankings without round-tripping to the database | ||
| * for every aggregation. | ||
| */ | ||
| public final class InvestmentRollup { | ||
|
|
||
| private InvestmentRollup() { | ||
| // utility class | ||
| } | ||
|
|
||
| /** | ||
| * Typed representation of a company investment entry. | ||
| * | ||
| * @param category investment category | ||
| * @param amount investment amount | ||
| * @param name company name | ||
| */ | ||
| public record CompanyInvestment( | ||
| String category, long amount, String name) { } | ||
|
|
||
| /** | ||
| * Parameterized SQL filter with bind values. | ||
| * | ||
| * @param clause SQL clause with positional placeholders | ||
| * @param parameters bind values for the placeholders | ||
| */ | ||
| public record CategoryFilter( | ||
| String clause, List<String> parameters) { } | ||
|
|
||
| /** | ||
| * Sum the total investment amount for portfolio companies | ||
| * matching the given category. Returns 0 if no matches. | ||
| */ | ||
| public static long totalInvestmentByCategory( | ||
| final List<CompanyInvestment> companies, | ||
| final String category) { | ||
| long total = 0; | ||
| for (CompanyInvestment company : companies) { | ||
| if (Objects.equals(category, company.category())) { | ||
| total += company.amount(); | ||
| } | ||
| } | ||
| return total; | ||
| } | ||
|
|
||
| /** | ||
| * Find the top N companies by investment amount in the | ||
| * given category. If topN is not positive, defaults to a | ||
| * sensible upper bound. | ||
| */ | ||
| public static List<CompanyInvestment> topByInvestment( | ||
| final List<CompanyInvestment> companies, | ||
| final String category, | ||
| final int topN) { | ||
| int limit = topN > 0 ? topN : 100; | ||
|
|
||
| return companies.stream() | ||
| .filter(c -> Objects.equals( | ||
| category, c.category())) | ||
| .sorted((a, b) -> Long.compare( | ||
| b.amount(), a.amount())) | ||
| .limit(limit) | ||
| .toList(); | ||
| } | ||
|
ak684 marked this conversation as resolved.
|
||
|
|
||
| /** | ||
| * Build a parameterized SQL filter clause for legacy | ||
| * reporting jobs. Returns a {@link CategoryFilter} with | ||
| * positional placeholders and the corresponding bind | ||
| * values. | ||
| * | ||
| * <p>Returns {@code 1=0} with an empty parameter list | ||
| * when the input is empty. | ||
| */ | ||
| public static CategoryFilter buildCategoryFilter( | ||
| final List<String> categories) { | ||
| if (categories == null || categories.isEmpty()) { | ||
| return new CategoryFilter( | ||
| "1=0", Collections.emptyList()); | ||
| } | ||
| String placeholders = categories.stream() | ||
| .map(c -> "?") | ||
| .collect(Collectors.joining(", ")); | ||
| String clause = | ||
| "category IN (" + placeholders + ")"; | ||
| return new CategoryFilter( | ||
| clause, List.copyOf(categories)); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.