Suggestions

[pzbitskiy]

Hello akappner,

Good job figuring out Miele protocol!

I have a few suggestions for going forward.

1. Format with black to make contributions easier. Maybe add a linter.
2. Switch to OpenAPI Spec for endpoints. This makes a difference in API discoverability both for people and agents.
3. A standalone HTTP server is universal but adds one more entity to manage. Instead, wrap it as HA integration that
   • Runs HTTP server against configured Miele appliances. Or, better, just HTTP client against Miele appliances since the server is just a proxy with unified API to Miele appliance.
   • Exposes devices/entities from configured Miele appliances (like one set of entities per configured appliances)

[akappner]

Hi,

Agreed with (1) and (2) -- Pull requests welcome on each of these, especially regarding an OpenAPI spec + codegen. :) Note that a Rust rewrite is coming ("dop2rs" directory). The Python server structure may eventually be discontinued. There should be a mechanism for different backends (DOP vs non DOP) and automatic selection. Another goal is to have an "interview" process at configuration time, gather all static device state, and then respond based on that. In other words, the server does not need to interrogate each device every time to know it's a washer -- unless the config changes, the device type cannot change.

(3) This project is not intended to exclusively cater to HA. While HA compatibility is a goal, you should not be forced to run HA if all you want is to control your Miele washer.

[pzbitskiy]

Thank you for response. The latest merged PR #16 solves (3).
I'll add a Makefile with formatter and linter, and recommend to run the formatter by yourself since it will touch almost all the lines in the repo.
I'll play around and maybe end up with some useful stuff like device library as a subpackage or maybe more user-friendly device registration flow.