docs: add critical note about LB service IP prohibition for internal pod access#707
docs: add critical note about LB service IP prohibition for internal pod access#707changluyi wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis pull request adds a critical warning to the MetalLB underlay configuration documentation, alerting users that LoadBalancer Service IPs cannot be accessed by internal Pods and are intended solely for external client traffic. ChangesMetalLB Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/en/configure/networking/how_to/kube_ovn/config_metallb_underlay.mdx (1)
13-13: Minor wording improvement: align “Service IP” vs “VIP” terminology.In this doc, you already use “LoadBalancer VIP” (Line 11) and “Access Underlay Subnet VIP” in the diagram. Consider tweaking Line 13 to explicitly say the VIP/LoadBalancer Service IP are the same entity (e.g., “the LoadBalancer Service VIP / LoadBalancer VIP”), to avoid readers thinking these are distinct IPs.
Suggested wording tweak (optional)
-> ⚠️ **Critical**: The LoadBalancer Service IP is prohibited from being accessed by internal Pods. This IP is intended for external client access only. +> ⚠️ **Critical**: The LoadBalancer VIP / Service IP is prohibited from being accessed by internal Pods. This IP is intended for external client access only.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/en/configure/networking/how_to/kube_ovn/config_metallb_underlay.mdx` at line 13, Update the sentence that currently reads "The LoadBalancer Service IP is prohibited..." to use consistent VIP terminology so readers know it's the same entity as "LoadBalancer VIP" and the diagram's "Access Underlay Subnet VIP"; replace "Service IP" with a combined term like "LoadBalancer Service VIP / LoadBalancer VIP" (or similar) to make the equivalence explicit and keep terminology aligned with the existing uses of "LoadBalancer VIP" and "Access Underlay Subnet VIP".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/en/configure/networking/how_to/kube_ovn/config_metallb_underlay.mdx`:
- Line 13: Update the sentence that currently reads "The LoadBalancer Service IP
is prohibited..." to use consistent VIP terminology so readers know it's the
same entity as "LoadBalancer VIP" and the diagram's "Access Underlay Subnet
VIP"; replace "Service IP" with a combined term like "LoadBalancer Service VIP /
LoadBalancer VIP" (or similar) to make the equivalence explicit and keep
terminology aligned with the existing uses of "LoadBalancer VIP" and "Access
Underlay Subnet VIP".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 87dcaff3-0e62-42fc-8c0b-9539faf5325a
📒 Files selected for processing (1)
docs/en/configure/networking/how_to/kube_ovn/config_metallb_underlay.mdx
eebb113 to
bac8f7f
Compare
Deploying alauda-container-platform with
|
| Latest commit: |
bac8f7f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c8b31933.alauda-container-platform.pages.dev |
| Branch Preview URL: | https://docs-add-lb-pod-access-warni-7vxf.alauda-container-platform.pages.dev |
Summary
config_metallb_underlay.mdxthat the MetalLB LoadBalancer Service IP must not be accessed by internal PodsChanges
docs/en/configure/networking/how_to/kube_ovn/config_metallb_underlay.mdx: Added critical note below the existing VIP-subnet constraintSummary by CodeRabbit