add cluster name label admission webhook#5
Open
jiazhiguang wants to merge 1 commit into
Open
Conversation
Add a generic core admission handler that enforces the cluster.x-k8s.io/cluster-name label for explicitly configured resources. The initial generated webhook rule targets Cluster create/update requests, requiring Cluster objects to carry the label themselves while still allowing future provider resources to inherit the label from labeled owners. Register the webhook in the core manager and envtest setup, expose it through the public webhook alias package, and generate the corresponding webhook/RBAC manifests. Add unit coverage for existing labels, owner-based mutation, missing owners, missing labels, multiple owners, and invalid owner references. Tested: - make GO_VERSION=1.25.9 generate-manifests-core - go test ./internal/webhooks ./webhooks . - git diff --check Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.