YFull tree download error

[br2890]

Where downloading the yfull tree as follows:
ycomp tree download-yfull --hg R-M269

I get the following error:

Downloading YFull tree from https://www.yfull.com/tree/R-M269/...
Finished downloading YFull tree.
Processing YFull tree...
UNEXPECTED ERROR: Invalid SNP 'Y485219(H)(T)'.

[br2890]

It seems to work when tweaking this tree_cmd section:

snp_name_pattern = re.compile(r"(?P[A-Z0-9+.=]+)(?P!|([A-Z]+))?")

to this:

snp_name_pattern = re.compile(r"(?P[A-Z0-9+.=]+)(?P(!|([A-Z]+))*)")

[alexreg]

Thanks for the report and suggested fix. I wasn't aware of the (T) label before, and am still not sure what it means, but in any case, there can clearly exist multiple brackets after the SNP, so this looks correct. Also, I don't believe YFull uses ! after SNPs any more, so I've removed that from the pattern too. Please let me know if I'm mistaken though.

Coming back to this project after a while, I've also just realised that large branches like R-M269 don't have their full subtrees displayed – one has to explicitly view the subtrees for various subclades (like R-Z2103). I wonder if it would be a useful feature to be able to recurse on these subclades, to ensure the entire subtree of some particular haplogroup is downloaded.

[br2890]

Thanks for the report and suggested fix. I wasn't aware of the (T) label before, and am still not sure what it means, but in any case, there can clearly exist multiple brackets after the SNP, so this looks correct. Also, I don't believe YFull uses ! after SNPs any more, so I've removed that from the pattern too. Please let me know if I'm mistaken though.

Coming back to this project after a while, I've also just realised that large branches like R-M269 don't have their full subtrees displayed – one has to explicitly view the subtrees for various subclades (like R-Z2103). I wonder if it would be a useful feature to be able to recurse on these subclades, to ensure the entire subtree of some particular haplogroup is downloaded.

Many thanks. This is a great tool.
Doesn't seem to be explained anywhere, but seems the T refers to SNPs which are recurrent in more than one haplogroup.

I've also noticed it with higher haplogroups like R-M269 there seems to be a cap on the number of downstream branches visible. Not sure if this is easier, but YFull also publishes json of their full tree on github which they've recently updated with v12.0

https://github.com/YFullTeam/YTree

Would be great to one day incorporate the FTDNA tree if possible. They also have a json tree structure.

Thanks,
Ben