Skip to content

arbitrary operations with no explanation in Greenhouses class #184

@lukaszgajewski

Description

@lukaszgajewski

There's 0 links or helpful explanations, for why we do things the way we do in the Greenhouses class.
Examples:
Rounding.
Why 8? Looks like it was added because for 8 it works and >8 it doesn’t which isn’t a good reason.

Why are we taking a mean here?

Wtf? Aside from an extremely over-complicated approach, why is there a magical "37"? The "42" seems like it's "37+5" (where 5 is also slightly arbitrary but I believe there is a source for that somewhere in the code) but that completely ignores the delay parameter. Presumably this is some attempt at a production ramp up function but it's done very confusingly and why is it linear and not expit, for instance?

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationenhancementNew feature or requestinvalidThis doesn't seem right

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions