From 278cfde935669c695115f0037d541e76d61d1579 Mon Sep 17 00:00:00 2001 From: Yiran Hu Date: Thu, 19 Mar 2026 11:59:55 -0700 Subject: [PATCH] fix: remove dead code in recommendations.py and replace print with logging in quiz_views.py - Remove duplicate return statement in get_similar_courses() (dead code) - Replace bare print(e) with logger.exception() in add_question view for proper error tracking Co-Authored-By: Claude Opus 4.6 (1M context) --- web/quiz_views.py | 5 ++++- web/recommendations.py | 1 - 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/web/quiz_views.py b/web/quiz_views.py index e86890a69..4e96d2593 100644 --- a/web/quiz_views.py +++ b/web/quiz_views.py @@ -1,4 +1,5 @@ import json +import logging import random from django.contrib import messages @@ -19,6 +20,8 @@ ) from .models import Quiz, QuizQuestion, UserQuiz +logger = logging.getLogger(__name__) + @login_required def quiz_list(request): @@ -182,7 +185,7 @@ def add_question(request, quiz_id): else: return redirect("quiz_detail", quiz_id=quiz.id) except Exception as e: - print(e) + logger.exception("Error adding question to quiz") # Re-raise the exception raise else: diff --git a/web/recommendations.py b/web/recommendations.py index ef7638323..b3a8fc28c 100644 --- a/web/recommendations.py +++ b/web/recommendations.py @@ -82,4 +82,3 @@ def get_similar_courses(course, limit=3): ) return similar_courses[:limit] - return similar_courses[:limit]