You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 25, 2026. It is now read-only.
When trying to stop the Dolphin console via the .stop() method, there seems to be an attribute error coming from an uninitialized variable.
Traceback (most recent call last):
File "<redacted>", line 110, in cleanup
console.stop()
File "<redacted>/env/lib/python3.10/site-packages/melee/console.py", line 293, in stop
self._slippstream.shutdown()
File "<redacted>/env/lib/python3.10/site-packages/melee/slippstream.py", line 71, in shutdown
self.server.close()
AttributeError: 'SlippstreamClient' object has no attribute 'server'
Upon closer inspection of SlippstreamClient, I noticed that there's a gamecube flag, which is used within the Console class (here). However strangely, it seems that the logic is swapped, where if the system property is set to "dolphin", then the gamecube flag is set to True and vice versa. I'm not sure if this is intended or if swapping the logic will work but it seems to be the obvious (but not necessarily correct) fix.
This fix should also allow Dolphin to be properly shutdown and the temporary directory to be removed if set.
When trying to stop the Dolphin console via the
.stop()method, there seems to be an attribute error coming from an uninitialized variable.Upon closer inspection of
SlippstreamClient, I noticed that there's agamecubeflag, which is used within theConsoleclass (here). However strangely, it seems that the logic is swapped, where if thesystemproperty is set to "dolphin", then thegamecubeflag is set toTrueand vice versa. I'm not sure if this is intended or if swapping the logic will work but it seems to be the obvious (but not necessarily correct) fix.This fix should also allow Dolphin to be properly shutdown and the temporary directory to be removed if set.