Skip to content

Dynamic RetroAchievements buffer size #1743

Description

@boomshroom

I was playing the Pokémon Unbound Professor Oak Challenge subset and got many messages in the log like this:

RetroAchievements state buffer too small. Need 878092 bytes

It seems that the buffer was initially statically set to 32KiB, and then expanded to 256KiB. The smallest power of 2 able to hold this buffer would be 1MiB, which, if 32KiB was enough at the beginning, would definitely be overkill for most games. Ideally it would be a dynamically allocated buffer to completely eliminate the chance of it being too small.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions