Summary
FILTER.m returns [subsetIndex, isDissimilar, isVISA, unif]. Both real call sites in
InstanceSpace.m discard isDissimilar and isVISA via ~ — confirmed by checking every
reference to either name across the entire codebase (grep -rn "isDissimilar\|isVISA" returns
hits only inside FILTER.m itself). Both are computed with genuine loop logic (tracking
per-instance closeness-check state across the whole FILTER run), so this isn't free — it's
real computation with no consumer.
isVISA's docstring calls it "visually important, but not subsetted away," which reads like a
half-built visualisation feature (highlighting borderline/near-duplicate instances differently
in a plot) that never got wired up to an actual plot.
Proposed change
Either:
- (a) build the consumer these outputs seem to have been intended for — e.g. a
InstanceSpace.plot() case or scriptpng.m overlay highlighting VISA instances, or
- (b) drop
isDissimilar/isVISA from FILTER.m's outputs and the loop bookkeeping that
produces them, since nothing uses them today.
Motivation
Dead computation costs maintenance attention and CPU cycles for no current benefit. Either
resolution is fine — the point is picking one deliberately rather than leaving unused output in
place indefinitely.
Acceptance criteria
Part of the v0.9.1 milestone. Source: full-file audit pass over every core algorithm file plus previously-grepped-only utility files — this finding was raised during the audit itself and deferred to this batch. Independent of batches 1, 2, 3, 5.
Summary
FILTER.mreturns[subsetIndex, isDissimilar, isVISA, unif]. Both real call sites inInstanceSpace.mdiscardisDissimilarandisVISAvia~— confirmed by checking everyreference to either name across the entire codebase (
grep -rn "isDissimilar\|isVISA"returnshits only inside
FILTER.mitself). Both are computed with genuine loop logic (trackingper-instance closeness-check state across the whole
FILTERrun), so this isn't free — it'sreal computation with no consumer.
isVISA's docstring calls it "visually important, but not subsetted away," which reads like ahalf-built visualisation feature (highlighting borderline/near-duplicate instances differently
in a plot) that never got wired up to an actual plot.
Proposed change
Either:
InstanceSpace.plot()case orscriptpng.moverlay highlighting VISA instances, orisDissimilar/isVISAfromFILTER.m's outputs and the loop bookkeeping thatproduces them, since nothing uses them today.
Motivation
Dead computation costs maintenance attention and CPU cycles for no current benefit. Either
resolution is fine — the point is picking one deliberately rather than leaving unused output in
place indefinitely.
Acceptance criteria
InstanceSpace.mupdated, no behaviour change tosubsetIndex/unifPart of the
v0.9.1milestone. Source: full-file audit pass over every core algorithm file plus previously-grepped-only utility files — this finding was raised during the audit itself and deferred to this batch. Independent of batches 1, 2, 3, 5.