Skip to content

Commit 878a4cc

Browse files
Merge branch 'main' into fix/pin-prerelease-versions
2 parents 3e7242a + 9a2a541 commit 878a4cc

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

src/schematics/setup/index.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,12 @@ import {
1818
} from '../utils';
1919
import { appPrompt, featuresPrompt, projectPrompt, userPrompt } from './prompts';
2020

21+
// FirebaseOptions keys — apps.sdkconfig responses include management-API extras that initializeApp() rejects.
22+
const firebaseOptionsKeys = [
23+
'apiKey', 'authDomain', 'databaseURL', 'projectId', 'storageBucket',
24+
'messagingSenderId', 'appId', 'measurementId', 'recaptchaSiteKey',
25+
];
26+
2127
export interface SetupConfig extends DeployOptions {
2228
firebaseProject: FirebaseProject,
2329
firebaseApp?: FirebaseApp,
@@ -92,8 +98,11 @@ export const ngAddSetupProject = (
9298
firebaseApp = await appPrompt(firebaseProject, undefined, { projectRoot });
9399

94100
const result = await firebaseTools.apps.sdkconfig('web', firebaseApp.appId, { nonInteractive: true, projectRoot });
95-
sdkConfig = result.sdkConfig;
96-
delete sdkConfig.locationId;
101+
sdkConfig = Object.fromEntries(
102+
firebaseOptionsKeys
103+
.filter(key => result.sdkConfig[key] !== undefined)
104+
.map(key => [key, result.sdkConfig[key]])
105+
);
97106
setupConfig.sdkConfig = sdkConfig;
98107
setupConfig.firebaseApp = firebaseApp;
99108
// set up data connect locally if data connect hasn't already been initialized.

src/schematics/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ export function parseDataConnectConfig(
375375
package: connectorJson.generate.javascriptSdk.package,
376376
angular: connectorJson.generate.javascriptSdk.angular,
377377
};
378-
} catch (_) {
378+
} catch (e) {
379379
console.error("Couldn't parse dataconnect.yaml", e);
380380
return null;
381381
}

0 commit comments

Comments
 (0)