Skip to content

Commit ba40380

Browse files
Merge branch 'main' into fix/schematic-firebase-options-allowlist
2 parents b3c5b0b + e4e652f commit ba40380

6 files changed

Lines changed: 10 additions & 7 deletions

File tree

src/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"@angular/platform-browser-dynamic": "^21.0.0",
3030
"@angular/platform-server": "^21.0.0",
3131
"rxjs": "~7.8.0",
32-
"firebase-tools": "^14.0.0"
32+
"firebase-tools": "^14.0.0 || ^15.0.0"
3333
},
3434
"peerDependenciesMeta": {
3535
"firebase-tools": { "optional": true },

src/schematics/firebaseTools.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ declare global {
88
var firebaseTools: FirebaseTools|undefined;
99
}
1010

11+
// The minimum firebase-tools version the schematics require.
12+
const minFirebaseToolsVersion = '14.0.0';
13+
1114
export const getFirebaseTools = () => globalThis.firebaseTools ?
1215
Promise.resolve(globalThis.firebaseTools) :
1316
new Promise<FirebaseTools>((resolve, reject) => {
@@ -44,8 +47,8 @@ export const getFirebaseTools = () => globalThis.firebaseTools ?
4447
globalThis.firebaseTools = firebaseTools;
4548
const version = firebaseTools.cli.version();
4649
console.log(`Using firebase-tools version ${version}`);
47-
if (semverCompare(version, '14.0.0') === -1) {
48-
console.error('firebase-tools version 14.0.0+ is required, please upgrade and run again');
50+
if (semverCompare(version, minFirebaseToolsVersion) === -1) {
51+
console.error(`firebase-tools version ${minFirebaseToolsVersion}+ is required, please upgrade and run again`);
4952
return Promise.reject();
5053
}
5154
return firebaseTools;

src/schematics/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ export function parseDataConnectConfig(
375375
package: connectorJson.generate.javascriptSdk.package,
376376
angular: connectorJson.generate.javascriptSdk.angular,
377377
};
378-
} catch (_) {
378+
} catch (e) {
379379
console.error("Couldn't parse dataconnect.yaml", e);
380380
return null;
381381
}

tsconfig.base.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"node_modules/@types"
1919
],
2020
"lib": [
21-
"es2018",
21+
"es2022",
2222
"dom"
2323
],
2424
"paths": {

tsconfig.build.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"compilerOptions": {
66
"outDir": "tools",
77
"skipLibCheck": true,
8-
"lib": ["es2019", "dom"],
8+
"lib": ["es2022", "dom"],
99
"module": "commonjs",
1010
"target": "ES2020",
1111
"plugins": [

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
],
1212
"lib": [
1313
"dom",
14-
"es2018"
14+
"es2022"
1515
]
1616
},
1717
"angularCompilerOptions": {

0 commit comments

Comments
 (0)