fix(ux): show unsaved changes warning on cancel in route and upstream…#3355
Open
vanshaj2023 wants to merge 1 commit into
Open
fix(ux): show unsaved changes warning on cancel in route and upstream…#3355vanshaj2023 wants to merge 1 commit into
vanshaj2023 wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi @Baoyuantop , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why submit this pull request?
What changes will this PR take into?
When editing a Route or Upstream and clicking Cancel, all unsaved form changes were silently discarded with no warning. This PR adds a confirmation dialog (same pattern as #3333) that appears only when the form has unsaved changes.
handleCancelinroutes/detail.$id.tsxandupstreams/detail.$id.tsxthat checksform.formState.isDirtybefore closinginfo.unsaved.*i18n keys across all 5 locales (en, zh, de, es, tr)Note:
form.formState.isDirtyis reliable here becauseform.reset(fetchedData)is called after data loads, correctly settingdefaultValues. This is different from #3333 where direct value comparison was needed.Related issues
fix #3344
Checklist: