From d4326a2fdfa970796bc51b44807384419ae24194 Mon Sep 17 00:00:00 2001 From: AlinsRan Date: Mon, 20 Jul 2026 14:04:25 +0800 Subject: [PATCH 1/2] test(lago): restore schema tests, skip only the docker-dependent case t/plugin/lago.t has been skipped as a whole file since #12903. TEST 1 is pure schema validation with no external dependency, so the file-level skip_all also took out coverage that never had a reason to be flaky. Narrow the skip to TEST 2, which clones the Lago repository and starts its docker compose stack. TEST 1 runs again. Relates to #12904 --- t/plugin/lago.t | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/t/plugin/lago.t b/t/plugin/lago.t index d97875e05ea6..6f3963209dbf 100644 --- a/t/plugin/lago.t +++ b/t/plugin/lago.t @@ -14,10 +14,11 @@ # See the License for the specific language governing permissions and # limitations under the License. # -use t::APISIX; +use t::APISIX 'no_plan'; -# This test cannot be executed normally at the moment, so it will be temporarily skipped and fixed in a later PR. -plan(skip_all => 'skip test case'); +# TEST 2 clones the Lago repository and brings up its docker compose stack, which +# makes it flaky in CI. It stays marked with `--- SKIP` until #12904 is resolved; +# the schema tests below have no external dependency and always run. repeat_each(1); no_long_string(); @@ -78,3 +79,4 @@ cd t && pnpm test plugin/lago.spec.mts 2>&1 failed to execute the script with status --- response_body eval qr/PASS plugin\/lago.spec.mts/ +--- SKIP From bd0a8f63d007ce6d34016ed2e31837ab765a275f Mon Sep 17 00:00:00 2001 From: AlinsRan Date: Mon, 20 Jul 2026 14:23:02 +0800 Subject: [PATCH 2/2] test(lago): give the skipped case a reason The lint forbids a bare `--- SKIP`, which is the right rule: a bypass without a stated reason is indistinguishable from an accident. --- t/plugin/lago.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/plugin/lago.t b/t/plugin/lago.t index 6f3963209dbf..5e7756db2503 100644 --- a/t/plugin/lago.t +++ b/t/plugin/lago.t @@ -79,4 +79,4 @@ cd t && pnpm test plugin/lago.spec.mts 2>&1 failed to execute the script with status --- response_body eval qr/PASS plugin\/lago.spec.mts/ ---- SKIP +--- SKIP: needs a live Lago stack cloned and started from the network (#12904)