Skip to content

Commit 0afcec6

Browse files
rafaelweingartnerDaanHoogland
authored andcommitted
[CLOUDSTACK-10307] Remove unused things from HostDaoImpl (#2438)
* Remove unused code from CloudZonesStartupProcessor * Removed unused @component annotation from HostDaoImpl And unused method
1 parent 9222da2 commit 0afcec6

3 files changed

Lines changed: 6 additions & 335 deletions

File tree

engine/schema/src/main/java/com/cloud/host/dao/HostDao.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ public interface HostDao extends GenericDao<HostVO, Long>, StateDao<Status, Stat
6161

6262
List<HostVO> listByHostTag(Host.Type type, Long clusterId, Long podId, long dcId, String hostTag);
6363

64-
long countRoutingHostsByDataCenter(long dcId);
65-
6664
List<HostVO> findAndUpdateApplianceToLoad(long lastPingSecondsAfter, long managementServerId);
6765

6866
boolean updateResourceState(ResourceState oldState, ResourceState.Event event, ResourceState newState, Host vo);

engine/schema/src/main/java/com/cloud/host/dao/HostDaoImpl.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import javax.persistence.TableGenerator;
3333

3434
import org.apache.log4j.Logger;
35-
import org.springframework.stereotype.Component;
3635

3736
import com.cloud.agent.api.VgpuTypesInfo;
3837
import com.cloud.cluster.agentlb.HostTransferMapVO;
@@ -70,7 +69,6 @@
7069
import com.cloud.utils.db.UpdateBuilder;
7170
import com.cloud.utils.exception.CloudRuntimeException;
7271

73-
@Component
7472
@DB
7573
@TableGenerator(name = "host_req_sq", table = "op_host", pkColumnName = "id", valueColumnName = "sequence", allocationSize = 1)
7674
public class HostDaoImpl extends GenericDaoBase<HostVO, Long> implements HostDao { //FIXME: , ExternalIdDao {
@@ -919,16 +917,6 @@ public long getNextSequence(long hostId) {
919917
return s_seqFetcher.getNextSequence(Long.class, tg, hostId);
920918
}
921919

922-
/*TODO: this is used by mycloud, check if it needs resource state Enabled */
923-
@Override
924-
public long countRoutingHostsByDataCenter(long dcId) {
925-
SearchCriteria<Long> sc = CountRoutingByDc.create();
926-
sc.setParameters("dc", dcId);
927-
sc.setParameters("type", Host.Type.Routing);
928-
sc.setParameters("status", Status.Up.toString());
929-
return customSearch(sc, null).get(0);
930-
}
931-
932920
@Override
933921
public boolean updateState(Status oldStatus, Event event, Status newStatus, Host vo, Object data) {
934922
// lock target row from beginning to avoid lock-promotion caused deadlock

0 commit comments

Comments
 (0)