Skip to content

Commit 1be37e4

Browse files
authored
Merge pull request #1819 from Accelerite/ListCapacityIssue
CLOUDSTACK-9653 The system capacity was not getting calculated correctly
2 parents 6cba86d + 97b6b11 commit 1be37e4

1 file changed

Lines changed: 3 additions & 19 deletions

File tree

engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import java.util.HashMap;
2424
import java.util.List;
2525
import java.util.Map;
26-
import java.util.Map.Entry;
2726

2827
import javax.inject.Inject;
2928

@@ -356,11 +355,11 @@ public List<SummedCapacity> listCapacitiesGroupedByLevelAndType(Integer capacity
356355

357356
switch (level) {
358357
case 1: // List all the capacities grouped by zone, capacity Type
359-
finalQuery.append(LIST_CAPACITY_GROUP_BY_CLUSTER_TYPE_PART2);
358+
finalQuery.append(LIST_CAPACITY_GROUP_BY_ZONE_TYPE_PART2);
360359
break;
361360

362361
case 2: // List all the capacities grouped by pod, capacity Type
363-
finalQuery.append(LIST_CAPACITY_GROUP_BY_CLUSTER_TYPE_PART2);
362+
finalQuery.append(LIST_CAPACITY_GROUP_BY_POD_TYPE_PART2);
364363
break;
365364

366365
case 3: // List all the capacities grouped by cluster, capacity Type
@@ -392,22 +391,7 @@ public List<SummedCapacity> listCapacitiesGroupedByLevelAndType(Integer capacity
392391
results.add(summedCapacity);
393392
}
394393

395-
HashMap<Integer, SummedCapacity> capacityMap = new HashMap<Integer, SummedCapacity>();
396-
for (SummedCapacity result: results) {
397-
if (capacityMap.containsKey(result.getCapacityType().intValue())) {
398-
SummedCapacity tempCapacity = capacityMap.get(result.getCapacityType().intValue());
399-
tempCapacity.setUsedCapacity(tempCapacity.getUsedCapacity()+result.getUsedCapacity());
400-
tempCapacity.setReservedCapacity(tempCapacity.getReservedCapacity()+result.getReservedCapacity());
401-
tempCapacity.setSumTotal(tempCapacity.getTotalCapacity()+result.getTotalCapacity());
402-
}else {
403-
capacityMap.put(result.getCapacityType().intValue(),result);
404-
}
405-
}
406-
List<SummedCapacity> summedCapacityList = new ArrayList<SummedCapacity>();
407-
for (Entry<Integer, SummedCapacity> entry : capacityMap.entrySet()) {
408-
summedCapacityList.add(entry.getValue());
409-
}
410-
return summedCapacityList;
394+
return results;
411395
} catch (SQLException e) {
412396
throw new CloudRuntimeException("DB Exception on: " + finalQuery, e);
413397
} catch (Throwable e) {

0 commit comments

Comments
 (0)